Opened 7 years ago

Closed 12 months ago

#11544 closed Cleanup/optimization (fixed)

adjust admin css to not depend upon the !important declaration.

Reported by: kez.knight@… Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords: css admin
Cc: robinchew@…, cmawebsite@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes


If I take a copy of the admin templates and modify base_site to include my own CSS in the block extrastyle, the existing administration css will attempt to overwrite my changes (even those I declare as !important) when loading certain views. For example, the loading of changelists.css will alter my rules as the change_list template also adds to extrastyle, and does so after mine are injected. I imagine that I could alter where I inject CSS to use the extrahead block instead of extrastyle, but it doesn't seem too logical to do so.

Mostly, I'm finding it nigh on impossible to move the filters menu to the left of a changelist, as the changelists.css says to add a margin-right with !important. I can't counteract this, as my stylesheet (complete with !important) is included beforehand, thus is superceded.

I propose rejigging the CSS to not be dependent upon !important (maybe it can be got around by using even finer grained specificity?) where possible so that we might customise the administration without having to resort to butchering the existing admin templates (and making future merges potentially a pain), which serve their purpose very well.

Change History (11)

comment:1 Changed 7 years ago by Alex

  • milestone 1.0.3 deleted
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Not a blocker for 1.0.3.

comment:2 Changed 7 years ago by russellm

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 5 years ago by julien

  • Severity set to Normal
  • Type set to Cleanup/optimization

comment:4 Changed 5 years ago by julien

  • UI/UX set

comment:5 Changed 5 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:6 Changed 5 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:7 Changed 5 years ago by aaugustin

  • UI/UX set

Revert accidental batch modification.

comment:8 Changed 3 years ago by robin

  • Cc robinchew@… added

comment:9 Changed 19 months ago by collinanderson

  • Cc cmawebsite@… added

comment:10 Changed 12 months ago by elky

  • Has patch set

comment:11 Changed 12 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from new to closed

In e23e7b2:

Fixed #11544 -- Removed !important rules in contrib.admin styles.

Note: See TracTickets for help on using tickets.
Back to Top