Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#11528 closed (fixed)

Chinese translation for Django-1.1

Reported by: qingfeng Owned by: nobody
Component: Translations Version: master
Severity: Keywords:
Cc: qingfeng@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I've attached a patch contains the newest Chinese translation for Django-1.1.

Attachments (4)

django-chinese-translation-rev11298.diff (6.3 KB) - added by qingfeng 6 years ago.
django.po (104.0 KB) - added by qingfeng 6 years ago.
djangojs.po (2.9 KB) - added by qingfeng 6 years ago.
django-chinese-translation-rev11312.diff (950 bytes) - added by qingfeng 6 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 6 years ago by qingfeng

  • Cc qingfeng@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 follow-up: Changed 6 years ago by russellm

  • milestone changed from 1.1 to 1.0 alpha

Two comments:

  1. Please generate patches against the root of the django tree, not against just the translations directory. This is especially important with Chinese, as there are _two_ chinese translations - zh_CN and zh_TW. From the patch alone, it's impossible to tell which one is being updated.
  2. Please ensure that your PO files compile before submitting. I get 2 duplicate message definitions when compiling your patch.

comment:3 Changed 6 years ago by russellm

  • milestone changed from 1.0 alpha to 1.1

Changed 6 years ago by qingfeng

Changed 6 years ago by qingfeng

Changed 6 years ago by qingfeng

comment:4 in reply to: ↑ 2 Changed 6 years ago by qingfeng

Replying to russellm:

Two comments:

  1. Please generate patches against the root of the django tree, not against just the translations directory. This is especially important with Chinese, as there are _two_ chinese translations - zh_CN and zh_TW. From the patch alone, it's impossible to tell which one is being updated.
  2. Please ensure that your PO files compile before submitting. I get 2 duplicate message definitions when compiling your patch.

Done.

comment:5 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [11310]) Fixed #11528 -- Updated Traditional Chinese translation. Thanks to Qing Feng.

comment:6 Changed 6 years ago by russellm

For future reference - you appear to have done the exact opposite to what I asked you to do.

Firstly - patches should be generated as a diff, generated against the root of the Django source tree.

Secondly - patches should compile. Your updated django.po still contains the duplicated translations that caused problems.

I have fixed these problems for the commit, but in future, it would be nice if the patches came ready-to-use.

Changed 6 years ago by qingfeng

comment:7 Changed 6 years ago by qingfeng

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sorry, the translation of some errors before, please use the latest patch file

comment:8 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [11315]) Fixed #11528 -- Updated Traditional Chinese translation. Thanks to Qing Feng.

comment:9 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top