Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#11528 closed (fixed)

Chinese translation for Django-1.1

Reported by: QingFeng Owned by: nobody
Component: Translations Version: master
Severity: Keywords:
Cc: qingfeng@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I've attached a patch contains the newest Chinese translation for Django-1.1.

Attachments (4)

django-chinese-translation-rev11298.diff (6.3 KB) - added by QingFeng 7 years ago.
django.po (104.0 KB) - added by QingFeng 7 years ago.
djangojs.po (2.9 KB) - added by QingFeng 7 years ago.
django-chinese-translation-rev11312.diff (950 bytes) - added by QingFeng 7 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by QingFeng

Cc: qingfeng@… added

comment:2 Changed 7 years ago by Russell Keith-Magee

milestone: 1.11.0 alpha

Two comments:

  1. Please generate patches against the root of the django tree, not against just the translations directory. This is especially important with Chinese, as there are _two_ chinese translations - zh_CN and zh_TW. From the patch alone, it's impossible to tell which one is being updated.
  2. Please ensure that your PO files compile before submitting. I get 2 duplicate message definitions when compiling your patch.

comment:3 Changed 7 years ago by Russell Keith-Magee

milestone: 1.0 alpha1.1

Changed 7 years ago by QingFeng

Changed 7 years ago by QingFeng

Attachment: django.po added

Changed 7 years ago by QingFeng

Attachment: djangojs.po added

comment:4 in reply to:  2 Changed 7 years ago by QingFeng

Replying to russellm:

Two comments:

  1. Please generate patches against the root of the django tree, not against just the translations directory. This is especially important with Chinese, as there are _two_ chinese translations - zh_CN and zh_TW. From the patch alone, it's impossible to tell which one is being updated.
  2. Please ensure that your PO files compile before submitting. I get 2 duplicate message definitions when compiling your patch.

Done.

comment:5 Changed 7 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [11310]) Fixed #11528 -- Updated Traditional Chinese translation. Thanks to Qing Feng.

comment:6 Changed 7 years ago by Russell Keith-Magee

For future reference - you appear to have done the exact opposite to what I asked you to do.

Firstly - patches should be generated as a diff, generated against the root of the Django source tree.

Secondly - patches should compile. Your updated django.po still contains the duplicated translations that caused problems.

I have fixed these problems for the commit, but in future, it would be nice if the patches came ready-to-use.

Changed 7 years ago by QingFeng

comment:7 Changed 7 years ago by QingFeng

Resolution: fixed
Status: closedreopened

Sorry, the translation of some errors before, please use the latest patch file

comment:8 Changed 7 years ago by Russell Keith-Magee

Resolution: fixed
Status: reopenedclosed

(In [11315]) Fixed #11528 -- Updated Traditional Chinese translation. Thanks to Qing Feng.

comment:9 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top