#11422 closed (duplicate)
Broken html in CheckboxSelectMultiple widget (with fix)
Reported by: | Jerome Leclanche | Owned by: | bmihelac |
---|---|---|---|
Component: | Forms | Version: | dev |
Severity: | Keywords: | ||
Cc: | adys.wh@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | yes | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The html in CheckboxSelectMultiple widget is broken, under the format <li><label%s>%s %s</label></li>. This itches Gecko (noticeable with firebug), and completely breaks webkit.
Attached patch, and before/after screenshot.
Attachments (4)
Change History (17)
by , 15 years ago
Attachment: | checkboxselectmultiple.patch added |
---|
comment:1 by , 15 years ago
Cc: | added |
---|
comment:3 by , 15 years ago
milestone: | → 1.2 |
---|---|
Needs tests: | set |
Triage Stage: | Unreviewed → Accepted |
comment:4 by , 15 years ago
This patch looks fine, but I think the checkboxes should be on the left, not the right. The css is the culprit here. Anyone want to fix it and upload a new patch?
by , 15 years ago
Attachment: | Screen shot 2010-02-28 at 11.12.18 AM.png added |
---|
Rendering in RTL locales
comment:5 by , 15 years ago
Existing patch also breaks down in RTL locales, see attached screenie (webkit)
comment:7 by , 15 years ago
The HTML is not broken. What is broken are CSS rules applied to the widget in the admin app. I have proposed a fix in #13131 (which was closed as a duplicate of this one).
comment:8 by , 15 years ago
Owner: | changed from | to
---|
I agree with patrys, CSS for admin is problematic and not HTML.
In forms.css label
s are floated to the left which is not ok good for multiple checkboxes because it makes whole li
element floated.
The simplest solution is to remove floating form label if it is inside li
element.
I am attaching patch for this.
by , 15 years ago
Attachment: | 11422.diff added |
---|
follow-up: 11 comment:10 by , 15 years ago
This one is was reported earlier so I'd say #12260 is a duplicate of this one.
comment:11 by , 15 years ago
comment:12 by , 15 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
This issue was fixed under ticket #12260, so I'm marking this ticket as a duplicate.
Patch