Opened 7 years ago

Closed 5 years ago

#11410 closed New feature (fixed)

Reorganize groups module in user admin

Reported by: Ben Spaulding Owned by: nobody
Component: contrib.auth Version: master
Severity: Normal Keywords: auth user admin
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

The groups form widget should be moved into the permissions module.

Groups are permissions tools so it makes sense to have
them inside the permissions module. Having the single group
form widget reside under the groups module (as the only item)
and separated from the permissions module creates visual
noise and may cause confusion.

Attachments (1)

reorganized-groups-user-admin.diff (1.2 KB) - added by Ben Spaulding 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Ben Spaulding

comment:1 Changed 7 years ago by Alex Gaynor

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedDesign decision needed

comment:2 Changed 6 years ago by Gabriel Hurley

Component: Contrib appscontrib.auth

comment:3 Changed 5 years ago by Julien Phalip

Needs tests: set
Severity: Normal
Type: New feature

comment:4 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset
Needs tests: unset
Triage Stage: Design decision neededAccepted
UI/UX: set

It may be even better to show the groups before the permissions, since it's a good idea to assign most permissions to groups, and give user permissions only in special cases.

I don't believe this really needs tests — if we have a good reason to change the order of the fields again in the future, we can always check the SVN logs. This page shows that the only previous change to the order of the fields was the fix for #11409.

comment:5 Changed 5 years ago by Julien Phalip

Resolution: fixed
Status: newclosed

In [17325]:

Fixed #11410 -- Moved the "Groups" field to the "Permissions" module in the auth.User admin form and modified the help texts for the user_permissions and groups model fields to reflect that change. Also did a little PEP8 cleanup and improved some docstrings while I was in the area. Thanks to benspaulding and Aymeric Augustin for the suggestions.

Note: See TracTickets for help on using tickets.
Back to Top