Opened 15 years ago
Closed 15 years ago
#11378 closed (duplicate)
Exceptions raised in Middleware process_request methods are not handled
Reported by: | ssdd | Owned by: | nobody |
---|---|---|---|
Component: | Core (Other) | Version: | dev |
Severity: | Keywords: | unhandled exception, middleware | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In django.core.handlers.base.BaseHandler.get_response, running the Middleware process_request methods is done before the big try-except block that handles 404s and other exceptions. I'm not sure if this is intentional, but it makes it hard, for example, to send a standard 404 from process_request by raising Http404, as all exceptions raised here are unhandled and make it to the web server.
I've included a quick patch to fix this. I might be wrong.
Thanks
Attachments (1)
Change History (2)
by , 15 years ago
comment:1 by , 15 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Dupe of #6094