Opened 15 years ago

Closed 14 years ago

Last modified 13 years ago

#11350 closed (fixed)

Support "local flavor" for Israel

Reported by: Yuval Adam Owned by: Yuval Adam
Component: contrib.localflavor Version: dev
Severity: Keywords: local flavor israel
Cc: Shai Berger Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Support django.contrib.localflavor for Israel

Attachments (7)

forms.py (1.7 KB ) - added by Yuval Adam 15 years ago.
Forms for Israel local flavor
il.py (1.4 KB ) - added by Yuval Adam 15 years ago.
Added regression tests
11350.diff (5.2 KB ) - added by Yuval Adam 14 years ago.
Updated proper diff, with tests and docs
django-11350.diff (5.8 KB ) - added by Alex Gaynor 14 years ago.
Converted tests to unittests.
django-11350.2.diff (5.5 KB ) - added by Alex Gaynor 14 years ago.
Use the luhn function as suggested by jezdez.
django-11350.3.diff (6.5 KB ) - added by Idan Gazit 14 years ago.
Adds checking for hyphenated checksum, cited references.
django-11350.4.diff (6.9 KB ) - added by Idan Gazit 14 years ago.
Adds more sensible docs.

Download all attachments as: .zip

Change History (23)

comment:1 by anonymous, 15 years ago

Owner: changed from nobody to anonymous
Status: newassigned

comment:2 by Yuval Adam, 15 years ago

Owner: changed from anonymous to Yuval Adam
Status: assignednew

by Yuval Adam, 15 years ago

Attachment: forms.py added

Forms for Israel local flavor

comment:3 by Yuval Adam, 15 years ago

Resolution: fixed
Status: newclosed

comment:4 by Alex Gaynor, 15 years ago

Resolution: fixed
Status: closedreopened

A ticket isn't fixed because a patch is uploaded, it's fixed when the code goes into Django.

comment:5 by Honza Král, 15 years ago

Needs tests: set

Also please add some tests to the forms you included. That way everybody will know if their work broke your code and would be able to fix it.

comment:6 by Russell Keith-Magee, 15 years ago

milestone: 1.1

We are well past the feature deadline for v1.1. This will need to wait until the next development phase.

by Yuval Adam, 15 years ago

Attachment: il.py added

Added regression tests

comment:7 by Alex Gaynor, 15 years ago

Triage Stage: UnreviewedAccepted

comment:8 by Jannis Leidel, 15 years ago

Needs documentation: set
Needs tests: unset
Patch needs improvement: set

Please provide a proper diff of the changes and a little bit of documentation.

comment:9 by Shai Berger, 15 years ago

Cc: Shai Berger added

by Yuval Adam, 14 years ago

Attachment: 11350.diff added

Updated proper diff, with tests and docs

comment:10 by Yuval Adam, 14 years ago

Has patch: set
milestone: 1.3
Needs documentation: unset
Patch needs improvement: unset

by Alex Gaynor, 14 years ago

Attachment: django-11350.diff added

Converted tests to unittests.

comment:11 by Alex Gaynor, 14 years ago

Does anyone know where I can find a description of the Israeli ID specification, google yields nothing of use.

comment:12 by Shai Berger, 14 years ago

Google yields plenty of results when you search in Hebrew... by following them, I got to the Luhn Algorithm -- the standard "mod 10" variant; numbers are 8 digits + checksum (9 digits altogether).

comment:13 by Jannis Leidel, 14 years ago

FYI, there is a luhn function in django.utils.checksums that is used by at least one localflavor.

by Alex Gaynor, 14 years ago

Attachment: django-11350.2.diff added

Use the luhn function as suggested by jezdez.

comment:14 by Idan Gazit, 14 years ago

Relevant (hebrew) wikipedia entries: the ID number format: the ID number format,
the checksum algorithm.

by Idan Gazit, 14 years ago

Attachment: django-11350.3.diff added

Adds checking for hyphenated checksum, cited references.

by Idan Gazit, 14 years ago

Attachment: django-11350.4.diff added

Adds more sensible docs.

comment:15 by Alex Gaynor, 14 years ago

Resolution: fixed
Status: reopenedclosed

(In [14223]) Fixed #11350 -- added an Israeli localflavor. Thanks to Yuval and Idan Gazit for their work on the patch.

comment:16 by Jacob, 13 years ago

milestone: 1.3

Milestone 1.3 deleted

Note: See TracTickets for help on using tickets.
Back to Top