Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#11316 closed (fixed)

Changeset [10966] broken python 2.3 support

Reported by: kylef Owned by: kylef
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

"FutureWarning: x<<y losing bits or changing sign will return a long in Python 2.4 and up"

Changeset [10966] used 1<<32 which will return 0 in python 2.3, and 4294967296L in newer versions. I have simply changed 1<<32 and hard coded the value in (4294967296L)

Attachments (1)

301ab5fb6095ef19c1c0cb12a3879e597d2317ee.diff (562 bytes) - added by kylef 5 years ago.
Patch attached and on my git repo at github http://github.com/kylef/django/commit/301ab5fb6095ef19c1c0cb12a3879e597d2317ee

Download all attachments as: .zip

Change History (4)

comment:1 Changed 5 years ago by Alex

  • milestone changed from 1.0.3 to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from 1.0 to SVN

comment:2 Changed 5 years ago by gwilson

  • Resolution set to fixed
  • Status changed from new to closed

(In [11004]) Fixed #11316 -- Fixed a Python 2.3 compatibilty issue with [10966] (in Python 2.3 on 32-bit machines, 1<<32 is 0). Thanks to kylef for the report and patch.

comment:3 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.