Opened 6 years ago

Closed 16 months ago

#11035 closed New feature (fixed)

urlify.js with Serbian alphabet

Reported by: janos Owned by: nobody
Component: contrib.admin Version: master
Severity: Normal Keywords: slug slugify urlify
Cc: mmitar@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Here is a patch for urilfy.js in admin application that should support Serbian alphabet. There are no collisions between existing and new mappings.

Attachments (2)

urlify.js.1.diff (326 bytes) - added by janos 6 years ago.
urlify.diff (1.2 KB) - added by claudep 4 years ago.
patch from #14345

Download all attachments as: .zip

Change History (13)

Changed 6 years ago by janos

comment:1 Changed 6 years ago by ubernostrum

  • milestone 1.1 deleted
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

We're only accepting critical/blocker-type bugs for the 1.1 milestone.

comment:2 Changed 6 years ago by janos

There is a small discussion on http://groups.google.com/group/Django-I18N/browse_thread/thread/3eda74c88874ba32 about that patch. Recently the Serbian translation was changed to Cyrillic alphabet and this patch is related to that. Without urlify.js with mappings for Serbian language, the translation is not complete. Please consider this patch for 1.1 milestone. It is critical for complete suppor the Serbian i18n.

comment:3 Changed 6 years ago by Alex

  • Triage Stage changed from Unreviewed to Accepted

comment:4 Changed 5 years ago by ramiro

#14345 is a duplicate and contains another patch for the issue.

comment:5 Changed 5 years ago by oggy

Ugh, late-night brain fart, forgot to check for duplicate issues. Thanks ramiro. This is essentially the same patch as mine, I don't mind either of them going in. Would one of the triagers consider marking this as ready for check-in?

Changed 4 years ago by claudep

patch from #14345

comment:6 Changed 4 years ago by claudep

  • Easy pickings unset
  • Severity set to Normal
  • Triage Stage changed from Accepted to Ready for checkin
  • Type set to Uncategorized

I don't think that js files are currently testable in Django.

comment:7 Changed 4 years ago by jezdez

  • Needs tests set
  • Triage Stage changed from Ready for checkin to Accepted

comment:8 Changed 4 years ago by julien

  • Type changed from Uncategorized to New feature

comment:9 Changed 4 years ago by julien

  • UI/UX unset

See related feature request in #8561.

comment:10 Changed 4 years ago by mitar

  • Cc mmitar@… added

I have added those translations to my improved JavaScript slug creation function which is using Unicode normalization too.

comment:11 Changed 16 months ago by Baptiste Mispelon <bmispelon@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 20948612c79b936424cb12cf9988713708232ced:

Fixed issues and added new scripts to urlify.js

Added the following scripts:

  • Lithuanian (thanks to petraszd for the patch)
  • Serbian (thanks to offy)
  • Azerbajani (thanks to Ali Ismayilov)

Fixed the following issues:

  • In Polish character map, some uppercase letters were converted to a lowercase ascii equivalent.
  • The letter Y with a diaeresis had a lowercase version but no uppercase.

The code was also simplified and cleaned up:

  • Use of var statements everywhere
  • Systematic use of semicolons
  • Proper looping over arrays and objects.

Thanks to @oinopion for his help in getting the javascript
into proper shape.

Fixes #8561, #11035.

Note: See TracTickets for help on using tickets.
Back to Top