Opened 9 years ago
Closed 7 years ago
#10907 closed New feature (fixed)
Adding google news sitemap support to django.contrib.sitemaps
Reported by: | Lakin Wecker | Owned by: | Lakin Wecker |
---|---|---|---|
Component: | contrib.sitemaps | Version: | 1.0 |
Severity: | Normal | Keywords: | |
Cc: | msimoens | Triage Stage: | Design decision needed |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | UI/UX: |
Description
Google News Sitemaps are very similar to normal sitemaps in that they build off of the sitemaps protocol. They add a new namespace to the xml file, along with some added news-specific attributes to eatch url.
This patch adds support for generation of these news sitemaps to the django.contrib.sitemaps application.
There were no tests for this package - so I have not added any news tests. I have however, made an attempt to update the documentation for sitemaps.
Attachments (1)
Change History (11)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
Cc: | msimoens added |
---|
comment:3 Changed 9 years ago by
Owner: | changed from nobody to Lakin Wecker |
---|---|
Status: | new → assigned |
There are a couple of small bugs that i discovered this morning - working through those now.
comment:5 Changed 9 years ago by
Triage Stage: | Unreviewed → Design decision needed |
---|
comment:6 Changed 9 years ago by
Ticket patch not updated.
I'm implementing this patch and can see the <news:keywords> content is still in place. Should read:
{% if url.keywords %}<news:keywords>
{% for keyword in keywords %}{{ url.keyword }}{% if not forloop.last %}, {% endif %}{% endfor %}
</news:keywords>{% endif %}
can't get the news sitemap content to pass through to the template correctly, likely this was part of the bugs that were cleaned up?
Please post the up to date patch.
comment:7 Changed 9 years ago by
There also a mobile sitemap format existing, see : http://www.google.com/support/webmasters/bin/answer.py?answer=34648&hl=en
comment:8 Changed 7 years ago by
Component: | Contrib apps → contrib.sitemaps |
---|
comment:9 Changed 7 years ago by
Severity: | → Normal |
---|---|
Type: | → New feature |
It looks like you left a bit of hard-coded data on line 14 of django/contrib/sitemaps/templates/news_sitemap.xml