Opened 15 years ago

Closed 15 years ago

Last modified 11 years ago

#10906 closed (fixed)

Aggregation support absent on postgres < 8.2

Reported by: Richard Davies <richard.davies@…> Owned by:
Component: Database layer (models, ORM) Version: dev
Severity: Keywords:
Cc: richard.davies@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Running the test suite on a clean check out of r10628, with PostgreSQL 8.1 and psycopg2, I get numerous errors from the regressiontests/aggregation_regress/, including:

    ProgrammingError: function stddev_pop(integer) does not exist
    ProgrammingError: function stddev_samp(integer) does not exist
    ProgrammingError: function var_pop(integer) does not exist
    ProgrammingError: function var_samp(integer) does not exist

I believe that these aggregates were first implemented in PostgreSQL 8.2, so either the aggregation code itself or at least the test cases should be conditional on that version.

See [10142] for an existing error message on PostgreSQL 8.2 to 8.2.4, which could perhaps be extended downwards?

Attachments (1)

10906-r10633-detect-early-postgresql.diff​ (2.6 KB ) - added by Richard Davies <richard.davies@…> 15 years ago.
Improve error message and avoid tests with errors on Postgresql <8.2

Download all attachments as: .zip

Change History (6)

by Richard Davies <richard.davies@…>, 15 years ago

Attachment: 10906-r10633-detect-early-postgresql.diff​ added

Improve error message and avoid tests with errors on Postgresql <8.2

comment:1 by Richard Davies <richard.davies@…>, 15 years ago

Has patch: set

(I meant to refer to #10142 and #10289, not [10142])

comment:2 by Russell Keith-Magee, 15 years ago

Triage Stage: Unreviewed → Accepted

This definitely needs to be done, but I'm going to wait until resolution on #10842 before committing, as this will make version comparisons much more robust.

comment:3 by Russell Keith-Magee, 15 years ago

Resolution: → fixed
Status: new → closed

(In [10731]) Fixed #10906 -- Added a check for PostgreSQL pre 8.2 when using StdDev/Variance aggregates. Thanks to Richard Davies for the report and patch.

comment:4 by Jacob, 13 years ago

milestone: 1.1

Milestone 1.1 deleted

comment:5 by Anssi Kääriäinen, 11 years ago

Component: ORM aggregation → Database layer (models, ORM)
Note: See TracTickets for help on using tickets.
Back to Top