Opened 18 years ago

Closed 15 years ago

#10797 closed Bug (fixed)

Set up Trac so post-commit hook sends emails

Reported by: Carl Meyer Owned by: nobody
Component: *.djangoproject.com Version:
Severity: Normal Keywords:
Cc: richard.davies@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As discussed in more detail ​here.

Not sure what is preventing this from happening, but according to ​this Trac issue this should work, but there are several possible reasons why it might be broken.

Change History (15)

comment:1 by Richard Davies <richard.davies@…>, 17 years ago

Cc: richard.davies@… added

comment:2 by Alex Gaynor, 17 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Jacob, 16 years ago

Resolution: → fixed
Status: new → closed

This should have been fixed by the update to 0.12.

comment:4 by Karen Tracey, 16 years ago

Resolution: fixed
Status: closed → reopened

This was not fixed by the recent trac update, in fact it is now worse. Previously if you subscribed to django-updates you got changeset notifications as part of that mail, now changeset notifications aren't sent at all. (Or, at any rate, I'm not getting any changeset notifications, not from django-updates nor for tickets I've commented on or done something with.)

comment:5 by Chris Beaven, 16 years ago

Severity: → Normal
Type: → Bug

comment:6 by Jannis Leidel, 15 years ago

Easy pickings: unset
Resolution: → fixed
Status: reopened → closed

I believe this was fixed recently.

comment:7 by Karen Tracey, 15 years ago

Resolution: fixed
Status: closed → reopened

No, the original request here has not been fixed: submitters and others on the cc list still do not get any mail notification when a commit closes (or references) a ticket. The fix that was made recently restores the sending of changeset notifications to django-updates, but those aren't sent by trac (I believe they come from an svn post-commit hook). People who have tickets they are interested in but who do not subscribe to django-updates still do not get any notification about when a code change has been made related to their ticket, which is a pretty major omission imo.

comment:8 by Jannis Leidel, 15 years ago

Cc: jannis+trac@… added

Just testing..

comment:9 by Jannis Leidel, 15 years ago

Resolution: → fixed
Status: reopened → closed

comment:10 by Jannis Leidel, 15 years ago

Resolution: fixed
Status: closed → reopened

Sorry for the noise..

comment:11 by Jannis Leidel, 15 years ago

Resolution: → fixed
Status: reopened → closed

comment:12 by Jannis Leidel, 15 years ago

Resolution: fixed
Status: closed → reopened

So, I definitely got the mail to the test email address after fixing the post-revprop-change commit hook script a little (the shebang was "#!/bin/sh\" instead of "#!/bin/sh".

comment:13 by Jannis Leidel, 15 years ago

Cc: jannis+trac@… removed

comment:14 by Jannis Leidel, 15 years ago

Okay, this doesn't seem to have fixed it. But, I found this in the log:

2011-04-28 06:20:34,437 Trac[commit_updater] ERROR: Failure sending notification on change to ticket #15713: ExtractionError: Can't extract file(s) to egg cache

So I've set PYTHON_EGG_CACHE in the commit hook scripts, too. Let's see if that fixes it..

comment:15 by Jannis Leidel, 15 years ago

Resolution: → fixed
Status: reopened → closed

Ack, that fixed it, as proven by the mail I got after committing r16117 and closing #15070.

Note: See TracTickets for help on using tickets.
Back to Top