Opened 6 years ago

Closed 4 years ago

#10797 closed Bug (fixed)

Set up Trac so post-commit hook sends emails

Reported by: carljm Owned by: nobody
Component: *.djangoproject.com Version:
Severity: Normal Keywords:
Cc: richard.davies@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX:

Description

As discussed in more detail here.

Not sure what is preventing this from happening, but according to this Trac issue this should work, but there are several possible reasons why it might be broken.

Change History (15)

comment:1 Changed 6 years ago by Richard Davies <richard.davies@…>

  • Cc richard.davies@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 6 years ago by Alex

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 4 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

This should have been fixed by the update to 0.12.

comment:4 Changed 4 years ago by kmtracey

  • Resolution fixed deleted
  • Status changed from closed to reopened

This was not fixed by the recent trac update, in fact it is now worse. Previously if you subscribed to django-updates you got changeset notifications as part of that mail, now changeset notifications aren't sent at all. (Or, at any rate, I'm not getting any changeset notifications, not from django-updates nor for tickets I've commented on or done something with.)

comment:5 Changed 4 years ago by SmileyChris

  • Severity set to Normal
  • Type set to Bug

comment:6 Changed 4 years ago by jezdez

  • Easy pickings unset
  • Resolution set to fixed
  • Status changed from reopened to closed

I believe this was fixed recently.

comment:7 Changed 4 years ago by kmtracey

  • Resolution fixed deleted
  • Status changed from closed to reopened

No, the original request here has not been fixed: submitters and others on the cc list still do not get any mail notification when a commit closes (or references) a ticket. The fix that was made recently restores the sending of changeset notifications to django-updates, but those aren't sent by trac (I believe they come from an svn post-commit hook). People who have tickets they are interested in but who do not subscribe to django-updates still do not get any notification about when a code change has been made related to their ticket, which is a pretty major omission imo.

comment:8 Changed 4 years ago by jezdez

  • Cc jannis+trac@… added

Just testing..

comment:9 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:10 Changed 4 years ago by jezdez

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sorry for the noise..

comment:11 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:12 Changed 4 years ago by jezdez

  • Resolution fixed deleted
  • Status changed from closed to reopened

So, I definitely got the mail to the test email address after fixing the post-revprop-change commit hook script a little (the shebang was "#!/bin/sh\" instead of "#!/bin/sh".

comment:13 Changed 4 years ago by jezdez

  • Cc jannis+trac@… removed

comment:14 Changed 4 years ago by jezdez

Okay, this doesn't seem to have fixed it. But, I found this in the log:

2011-04-28 06:20:34,437 Trac[commit_updater] ERROR: Failure sending notification on change to ticket #15713: ExtractionError: Can't extract file(s) to egg cache

So I've set PYTHON_EGG_CACHE in the commit hook scripts, too. Let's see if that fixes it..

comment:15 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from reopened to closed

Ack, that fixed it, as proven by the mail I got after committing r16117 and closing #15070.

Note: See TracTickets for help on using tickets.
Back to Top