url tag does not work within inclusion_tags when current_app is needed

[raony araújo]

suppose we deployed the same app two times (e.g., django-admin), each include in urls.py has tha namespace and app_name set.

now we create a custom tag (with the inclusion_tag function of Library) that renders a specific template which has an url tag trying to resolve an url from the mentioned app.

then we create a view which set current_app on the RequestContext object and renders a template with the custom tag; the reverse inside the url_tag at the included template fails to resolve to the right app as if the current_app was not set.

[Łukasz Rekucki]

A regression test is also required. tests/regressiontests/templates/custom.py is most likely the right place.

[Matthias Kestenholz]

Refreshed patch for current SVN trunk.

Only change: Made sure it applies correctly and added strip() calls so that the trailing newline in the newly added template does not cause test failures.

[Gary Reynolds]

I encountered this myself just recently and had started working on my own patch.

When fixing this we should also provide coverage for the use_l10n attribute as well.

[Gary Reynolds]

I've added a new patch in attachment:15070_goodtune.diff​ which also deals with the use_l10n case I mentioned in comment:5.

The tests follow the same convention to the previous suggestions. If there is a better approach for writing tests for inclusion tags then please let me know and I'll review.

[Jannis Leidel]

In [16117]:

Fixed #15070 -- Also pass current_app and use_l10n in inclusion_tags. Thanks, raony, mk and goodtune.