Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#10691 closed (fixed)

Comments feed not translated

Reported by: zgoda Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords: i18n translation feeds
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

django.contrib.comments.feeds.LatestComment has untranslated user-visible strings. Attached patch adds translations for these strings.

Attachments (2)

comments.feed.translation.diff (1.1 KB) - added by zgoda 6 years ago.
translated strings
comments.feed.trans-revised.diff (1.2 KB) - added by zgoda 6 years ago.
revised patch with named placeholders

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by zgoda

translated strings

comment:1 Changed 6 years ago by thatch

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 6 years ago by garcia_marc

  • Patch needs improvement set

I think that following django's standards is better doing something like:

_("%(site_name)s comments") % dict(site_name=self._site.name)

than

_("%s comments") % self._site.name

Specially that it helps translators understanding better the meaning of the sentence.

Changed 6 years ago by zgoda

revised patch with named placeholders

comment:3 Changed 6 years ago by zgoda

Right, I just uploaded revised patch that uses named placeholders.

comment:4 Changed 6 years ago by ramiro

See also #10633

comment:5 Changed 6 years ago by ramiro

See also #10691

comment:6 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [10427]) Fixed #10633, #10691: marked strings in the comments app for translation. Thanks, zgoda.

comment:7 Changed 6 years ago by jacob

(In [10430]) [1.0.X] Fixed #10633, #10691: marked strings in the comments app for translation. Thanks, zgoda. Backport of r10427 from trunk.

comment:5 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top