#10691 closed (fixed)
Comments feed not translated
| Reported by: | Jarek Zgoda | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.comments | Version: | dev |
| Severity: | Keywords: | i18n translation feeds | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | no | UI/UX: | no |
Description
django.contrib.comments.feeds.LatestComment has untranslated user-visible strings. Attached patch adds translations for these strings.
Attachments (2)
Change History (10)
by , 15 years ago
| Attachment: | comments.feed.translation.diff added |
|---|
comment:1 by , 15 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 15 years ago
| Patch needs improvement: | set |
|---|
I think that following django's standards is better doing something like:
_("%(site_name)s comments") % dict(site_name=self._site.name)
than
_("%s comments") % self._site.name
Specially that it helps translators understanding better the meaning of the sentence.
by , 15 years ago
| Attachment: | comments.feed.trans-revised.diff added |
|---|
revised patch with named placeholders
comment:6 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:7 by , 15 years ago
Note:
See TracTickets
for help on using tickets.
translated strings