Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#10691 closed (fixed)

Comments feed not translated

Reported by: Jarek Zgoda Owned by: nobody
Component: contrib.comments Version: dev
Severity: Keywords: i18n translation feeds
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

django.contrib.comments.feeds.LatestComment has untranslated user-visible strings. Attached patch adds translations for these strings.

Change History (10)

by Jarek Zgoda, 16 years ago

Attachment: comments.feed.translation.diff​ added

translated strings

comment:1 by thatch, 16 years ago

milestone: → 1.1
Triage Stage: Unreviewed → Accepted

comment:2 by Marc Garcia, 16 years ago

Patch needs improvement: set

I think that following django's standards is better doing something like:

_("%(site_name)s comments") % dict(site_name=self._site.name)

than

_("%s comments") % self._site.name

Specially that it helps translators understanding better the meaning of the sentence.

by Jarek Zgoda, 16 years ago

Attachment: comments.feed.trans-revised.diff​ added

revised patch with named placeholders

comment:3 by Jarek Zgoda, 16 years ago

Right, I just uploaded revised patch that uses named placeholders.

comment:4 by Ramiro Morales, 16 years ago

See also #10633

comment:5 by Ramiro Morales, 16 years ago

See also #10691

comment:6 by Jacob, 16 years ago

Resolution: → fixed
Status: new → closed

(In [10427]) Fixed #10633, #10691: marked strings in the comments app for translation. Thanks, zgoda.

comment:7 by Jacob, 16 years ago

(In [10430]) [1.0.X] Fixed #10633, #10691: marked strings in the comments app for translation. Thanks, zgoda. Backport of r10427 from trunk.

comment:5 by Jacob, 13 years ago

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top