Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#10585 closed (fixed)

Incorrect query string built by utils.next_redirect if next parameter already contains a query string

Reported by: benbest86 Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the comments app, views.utils.next_redirect appends a '?' and query string key/value pairs to the next parameter regardless of whether the next parameter already has a query string appended.

e.g. if next = /path/to/url?key=value then next_redirect redirects to /path/to/url/?key=value?c=13 or something along those lines.
Simple patch is attached, this is my first contribution, so apologies for any missed protocol...

Thanks,

Ben

Attachments (1)

patch01.diff (659 bytes) - added by benbest86 5 years ago.

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by benbest86

comment:1 Changed 5 years ago by jacob

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [10424]) Fixed #10585: comment redirects built from the next parameter now work correctly when next already contains a query string.

comment:3 Changed 5 years ago by jacob

(In [10425]) [1.0.X] Fixed #10585: comment redirects built from the next parameter now work correctly when next already contains a query string. Backport of r10424 from trunk.

comment:4 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.