Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#10585 closed (fixed)

Incorrect query string built by utils.next_redirect if next parameter already contains a query string

Reported by: benbest86 Owned by: nobody
Component: contrib.comments Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the comments app, views.utils.next_redirect appends a '?' and query string key/value pairs to the next parameter regardless of whether the next parameter already has a query string appended.

e.g. if next = /path/to/url?key=value then next_redirect redirects to /path/to/url/?key=value?c=13 or something along those lines.
Simple patch is attached, this is my first contribution, so apologies for any missed protocol...

Thanks,

Ben

Attachments (1)

patch01.diff (659 bytes ) - added by benbest86 15 years ago.

Download all attachments as: .zip

Change History (5)

by benbest86, 15 years ago

Attachment: patch01.diff added

comment:1 by Jacob, 15 years ago

milestone: 1.1
Triage Stage: UnreviewedAccepted

comment:2 by Jacob, 15 years ago

Resolution: fixed
Status: newclosed

(In [10424]) Fixed #10585: comment redirects built from the next parameter now work correctly when next already contains a query string.

comment:3 by Jacob, 15 years ago

(In [10425]) [1.0.X] Fixed #10585: comment redirects built from the next parameter now work correctly when next already contains a query string. Backport of r10424 from trunk.

comment:4 by Jacob, 13 years ago

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top