#10585 closed (fixed)
Incorrect query string built by utils.next_redirect if next parameter already contains a query string
| Reported by: | benbest86 | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.comments | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In the comments app, views.utils.next_redirect appends a '?' and query string key/value pairs to the next parameter regardless of whether the next parameter already has a query string appended.
e.g. if next = /path/to/url?key=value then next_redirect redirects to /path/to/url/?key=value?c=13 or something along those lines.
Simple patch is attached, this is my first contribution, so apologies for any missed protocol...
Thanks,
Ben
Attachments (1)
Change History (5)
by , 17 years ago
| Attachment: | patch01.diff added |
|---|
comment:1 by , 17 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:3 by , 17 years ago
Note:
See TracTickets
for help on using tickets.
(In [10424]) Fixed #10585: comment redirects built from the
nextparameter now work correctly whennextalready contains a query string.