Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#10538 closed (fixed)

App name conflicts with CSS / HTML in admin

Reported by: justinlilly Owned by: justinlilly
Component: Contrib apps Version: 1.0
Severity: Keywords: admindocs
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I have an app called "content". When I look through the admin generated documentation, the styles of the admin's div#content are conflicting with this. I'd propose prepending something to the auto-generated id's. #app-content or some such.

I think its also important to note that this isn't just cosmetic, the quick jump nav on the upper left of the page doesn't work b/c it tries to jump to the #content div, which is obviously much surrounding much of the page.

Before you say it, I know that "content" is rather generic and I could just rename my app, but I still think this is unintended consequence which could be fixed. I'll work on a patch for this later, just wanted to be sure I logged it.

Attachments (2)

duplicate_ids.jpg (8.8 KB) - added by justinlilly 6 years ago.
A picture of it visually looks like.
10538_html_id_prefix.diff (593 bytes) - added by justinlilly 6 years ago.
simple patch which adds a prefix for the ID used in admindocs model list.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by justinlilly

A picture of it visually looks like.

comment:1 Changed 6 years ago by mtredinnick

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Your proposed fix sounds reasonable: changing the app-specific ids, rather than the general ones.

Changed 6 years ago by justinlilly

simple patch which adds a prefix for the ID used in admindocs model list.

comment:2 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [10343]) Fixed #10538: use a prefix for HTML ids on the admin doc page to avoid conflicts with existing elements. Thanks, Justin Lilly.

comment:3 Changed 6 years ago by jacob

(In [10344]) [1.0.X] Fixed #10538: use a prefix for HTML ids on the admin doc page to avoid conflicts with existing elements. Thanks, Justin Lilly. Backport of r10343 from trunk.

comment:4 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top