#10372 closed (fixed)
get_svn_revision() should be more robust
Reported by: | rjaarts | Owned by: | Matt Boersma |
---|---|---|---|
Component: | Core (Other) | Version: | 1.0 |
Severity: | Keywords: | version Google App Engine GAE | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
When Django is used in the Google App Engine (GAE)environment there is a problem with the django get_svn_revision() function. This occurs only in when using the GAE SDK and when a checked out version of Django is used.
The get_svn_revision() function checks for existence of a ".svn/entries" file. This file will exist if Django was checked out, but GAE will prevent reading that file, which results in an raised error. Would be nice if this error could be catched, and perhaps a warning logged, and simple "unknown" would be returned.
Attachments (1)
Change History (10)
comment:1 by , 16 years ago
milestone: | 1.1 beta → 1.1 |
---|
comment:2 by , 16 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 16 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 16 years ago
Description: | modified (diff) |
---|---|
Has patch: | set |
Summary: | get_svn_version() should be more robust → get_svn_revision() should be more robust |
by , 16 years ago
Attachment: | 10372.diff added |
---|
comment:5 by , 16 years ago
There is another problem with get_svn_version
. Tortoise SVN client (don't known if others do so too) allows for changing default name of directory .svn
to _svn
. Using this feature will cause get_svn_version
to always fail, since .svn
is hardcoded.
comment:6 by , 16 years ago
This is a utility function that works for a normal subversion checkout. So if Tortoise SVN renames things to something non-standard, they just don't see the revision number. Same as people who aren't using subversion as their primary system for checking out the code (I never see the version number, for example). We shouldn't raise errors, but if the version number doesn't display, that's the way it goes. No harm done. If you must see the version number, don't rename the .svn directory and always use subversion to check out the code.
comment:7 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
This isn't a feature and thus isn't for the 1.1 beta.