login.html example FORM tag is wrong in http://docs.djangoproject.com/en/dev/topics/auth/
|Reported by:||jkafader||Owned by:||Kevin Kubasik|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Hi I just thought I'd pass this along:
the ACTION parameter on the FORM tag for your sample login.html template is almost certainly wrong. It should not be '.' -- I'm not an expert on FORM ACTION but I think it should instead be , which at least worked for me.
This cost me, actually, about an hour of development time, thinking there was something drastically wrong with the way I was passing or handling the ?next= parameter in my login form. You see, an action of '.' cuts off the GET CGI string, making your form unable to redirect properly (django.contrib.auth.views.login gets the 'redirect_to' variable from the GET string, not from POST), but still, confusingly, logging in the user correctly.
This really took up a lot of time to figure out, I guess I should have gone with my original instinct of action="" with my login.html rather than slavishly copying the one in the docs. But I just thought I'd let you know about an unnecessary gotcha.
Change History (12)
comment:1 Changed 8 years ago by
|Patch needs improvement:||unset|
comment:8 Changed 7 years ago by
|Owner:||changed from nobody to Kevin Kubasik|
|Status:||reopened → new|