login.html example FORM tag is wrong in http://docs.djangoproject.com/en/dev/topics/auth/

[jkafader]

Hi I just thought I'd pass this along:

the ACTION parameter on the FORM tag for your sample login.html template is almost certainly wrong. It should not be '.' -- I'm not an expert on FORM ACTION but I think it should instead be , which at least worked for me.

This cost me, actually, about an hour of development time, thinking there was something drastically wrong with the way I was passing or handling the ?next= parameter in my login form. You see, an action of '.' cuts off the GET CGI string, making your form unable to redirect properly (django.contrib.auth.views.login gets the 'redirect_to' variable from the GET string, not from POST), but still, confusingly, logging in the user correctly.

This really took up a lot of time to figure out, I guess I should have gone with my original instinct of action="" with my login.html rather than slavishly copying the one in the docs. But I just thought I'd let you know about an unnecessary gotcha.

--james

[jkafader]

sorry the above should read "It should not be '.' -- I'm not an expert on FORM ACTION, but I think it should instead be "" (empty string), which at least worked for me." I think the "" (empty string) double single quotes got stuck in the wiki formatting filter.

---james

[(none)]

Milestone post-1.0 deleted

[Kyle Fuller]

Simply use:

    <form method="post" action="{% url django.contrib.auth.views.login %}">

[Kyle Fuller]

Diff for docs/topics/auth.txt

[Kyle Fuller]

Diff for docs/topics/auth.txt

[Jacob]

Please don't mark tickets as fixed until the change actually gets checked into Django.

[James Bennett]

(In [10269]) Fixed #10306: Corrected form action in auth login example.

[Jacob]

Milestone 1.1 deleted