change the way ModelForms are instantiated in add_view, change_view

[tangc]

add_view and change_view have the following code:

ModelForm = self.get_form(request)
...
form = ModelForm(request.POST, request.FILES)

or:

 form = ModelForm(initial=initial)

or:

 form = ModelForm(request.POST, request.FILES, instance=obj)

I would propose:

if isinstance(ModelForm, ModelFormMetaclass):
    form = ModelForm(request.POST, request.FILES)
else
    form = ModelForm

This way gives the flexibility to override the function get_form(self, request, obj=None, **kwargs), which could return a modelform_factory(self.model, **defaults) or an instance of a model form.

[Alex Gaynor]

My inclination is that this is the wrong way to go about doing this, an "instiate_form" hook or somethign similar is a much better API design IMO.

[(none)]

Milestone post-1.0 deleted

[Tay Ray Chuan]

Changed the summary to be more informative.

[Julien Phalip]

Reformatted description to be more readable.