Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#1020 closed defect (fixed)

[patch]mutually referential models

Reported by: rjwittams Owned by: adrian
Component: contrib.admin Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Subsumes #746.

Allows mutually referential models. The string name is used as an argument to the ForeignKey.
Most field special casing in meta/ is moved to individual fields.

I think it should go in the "messing with models" branch.

Attachments (1)

mutually-referential.diff (67.6 KB) - added by rjwittams 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by rjwittams

comment:1 Changed 10 years ago by ian@…

this patch looks pretty self contained, and is backward compatible isn't it?

I mean..joe coder will not have to change 1 thing in his code if this patch went into the main branch.
the messing with models branch is about a much larger, incompatible change.

I vote stick it in the main branch, and fix the bugs IF they come.
I've been using #746 for months now with no problems.

comment:2 Changed 10 years ago by rjwittams

Yes, it is backwards compatible AFAIK. So it could go in trunk.

comment:3 Changed 10 years ago by rjwittams

  • Summary changed from mutually referential models to [patch]mutually referential models

comment:4 Changed 10 years ago by adrian

  • Status changed from new to assigned

Thanks for this, rjwittams. My plan is to explore the patch and eventually apply it to trunk. But the removing-magic stuff will definitely get its own branch.

comment:5 Changed 10 years ago by adrian

(In [1591]) Negligible refactoring in django.core.meta.fields and django.contrib.admin.views.main. Taken from #1020. Refs #1020

comment:6 Changed 10 years ago by adrian

  • Resolution set to fixed
  • Status changed from assigned to closed

This is working in magic-removal.

Note: See TracTickets for help on using tickets.
Back to Top