allow model instance as argument to HttpResponseRedirect constructor

[Daniel Pope <dan@…>]

Something I do fairly often is

return HttpResponseRedirect(model_inst.get_absolute_url())

It just occurred to me that

return HttpResponseRedirect(model_inst)

would be much more concise, and in the long run, more legible.

Obviously this would constitute an association between django.http and django.db.model which I believe we try to avoid in general. Perhaps a more appropriate for such a shortcut would be

from django.shortcuts import redirect
return redirect(model_inst)

[Jacob]

I think django.shortcuts.redirect is a good idea.

[Dan Watson]

Shortcut and documentation

[Dan Watson]

Forgot the versionadded

[Russell Keith-Magee]

A few quick comments:

1. The patch needs tests. This sort of thing is easily testable using the builtin test client.
2. I'm not entirely clear why line 69 (the hasattr(obj, 'get_absolute_url') and obj.get_absolute_url() or obj bit) is required. Is there some condition I'm missing where returning just the object would make sense? The only case I can think of is so you can use redirect() as a shortcut for HttpResponseRedirect(), but frankly, I'd rather see the separation of concerns maintained - HttpResposeRedirect handling a literal URL, and redirect handling the get_absolute_url case.
3. There are a couple of minor PEP8 issues - most notably, extra spaces around function arguments. This is easy for us to fix prior to commit, but it would be even nicer if we didn't have to fix them :-)

[Jacob]

(In [10108]) Fixed #10194: added django.shortcuts.redirect, a do-what-I-mean redirect shortcut. See the docs at topics/http/shortcuts for details.

[Gary Wilson]

(In [10111]) Added a versionadded directive to new redirect shortcut (refs #10194).

[Jacob]

Milestone 1.1 beta deleted