Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#1012 closed defect (wontfix)

[patch] ManyToMany not working in Manipulators when the form control isn't of the same style as the control in the admin

Reported by: Gustavo Picon <gpicon@…> Owned by: Adrian Holovaty
Component: Core (Other) Version: master
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

ManyToMany not working in Manipulators when the form control isn't of the same style as the control in the admin

For instance, if raw_id_admin=True, the admin will show an editbox, but if you use a select-multiple in your app, manipulator.save() will only save the first selected item.

A patch has been submitted.

Attachments (3)

coremeta.diff (1.4 KB) - added by Gustavo Picon <gpicon@…> 11 years ago.
coremeta2.diff (1.4 KB) - added by Gustavo Picon <gpicon@…> 11 years ago.
re-submitting without the debugging stuff
coremeta3.diff (1.4 KB) - added by gpicon@… 11 years ago.
no longer imports types

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by Gustavo Picon <gpicon@…>

Attachment: coremeta.diff added

Changed 11 years ago by Gustavo Picon <gpicon@…>

Attachment: coremeta2.diff added

re-submitting without the debugging stuff

Changed 11 years ago by gpicon@…

Attachment: coremeta3.diff added

no longer imports types

comment:1 Changed 11 years ago by Jacob

Resolution: wontfix
Status: newclosed

I'm very much unclear on what this does (the patch doesn't seem to have any explanation of what it's doing). I'm also worried by the bare except clause in there, and by the monkeying with type-checking.

Finally (and this why I'm marking WONTFIX), this is easy enough to work around at the manipulator level. The automatic manipulators do (and should) take into account admin options, so if you want to use a public view differently, write a different manipulator.

Note: See TracTickets for help on using tickets.
Back to Top