ModelAdmin.render_change_form should not override the 'has_delete' option

[rajeesh]

The methods, add_view and change_view in class ModelAdmin in options.py, call another method, render_change_form, to display the add and edit forms respectively. The add_view passes it a context dictionary which includes a 'has_delete' option which in turn makes the 'Delete' button invisible from the add form. When I wanted to make the Delete button invisible from the edit form also (based on specific conditions), I hoped a similar approach in change_view, that is, including 'has_delete' option may help the cause. But render_change_form seems to ignore that option explained below:

def render_change_form(self, request, context, add=False, change=False, form_url='', obj=None): 
    #few lines here
    context.update({
        #few_other_options_here
        ################################################################
        'has_delete_permission': self.has_delete_permission(request, obj)
        ################################################################
        # The above line is what overrides the has_delete option passed!
   #more code here

Changing the above mentioned line to

'has_delete_permission': context.get('show_delete',True) and \
                        self.has_delete_permission(request, obj) 

may solve the problem. By this way, the developer can decide when to make the Delete button visible just by passing an extra context option, 'has_delete' to the change_view.

Looking forward to alternative suggestions and comments

[Ramiro Morales]

(edited description to make it legible, next time please use the Preview button)

[anonymous]

Well, what happened to this?

[(none)]

Milestone post-1.0 deleted

[Jacob]

A better approach would be to just make a custom template for the model in question; see ​http://docs.djangoproject.com/en/dev/ref/contrib/admin/#overriding-admin-templates

[patcoll]

Just ran into the same problem. The logic that produces a True or False for show_delete_link in django.contrib.admin.templatetags.admin_modify seems a bit flawed because the value of show_delete in the passed context is essentially always ignored because the changed boolean is hard-coded to True by the admin system if you are viewing the change_view` with a bound Form.

I've attached a patch that ensures that show_delete is checked if it exists, otherwise it always displays the delete link.

[Chris Beaven]

From a quick look at the logic changes in the attached patch, it looks like a valid issue.

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Aymeric Augustin]

Revert accidental batch modification.

[David Gouldin]

Updated patcoll's patch to current trunk and added a test.

[Julien Phalip <jphalip@…>]

In [01c392623d988d7486bdaa870886df0ea3da5fa7]:

Fixed #10057 -- Ensured that the 'show_delete' context variable in the admin's change view actually controls the display of the delete button. Thanks to rajeesh for the report, to patcoll for the patch, and to David Gouldin for the test.