#9957 closed (fixed)
Feeds discard timezone information from pubdate
| Reported by: | Rajat Upadhyaya | Owned by: | Eric Holscher |
|---|---|---|---|
| Component: | contrib.syndication | Version: | dev |
| Severity: | Keywords: | atom rss feeds timezone | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Changeset 8216 which fixed 7016 calculates the timezone offset with respect to the server timezone. Even if timezone information is already present in the pubdate field (i.e. the datetime.datetime object returned by item_pubdate already contains a tzinfo component), it is discarded. The attached patch checks pubdate for attached timezone information before calculating the offset.
Attachments (1)
Change History (8)
Changed 15 years ago by
| Attachment: | feeds_timezone_check.diff added |
|---|
comment:1 Changed 15 years ago by
| milestone: | post-1.0 |
|---|
comment:2 Changed 15 years ago by
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:3 Changed 15 years ago by
| Needs tests: | set |
|---|
Looks sane to me. Skips the timezone creation magic when it already exists.
Needs tests. I'll do that now.
comment:4 Changed 15 years ago by
| Owner: | changed from nobody to Eric Holscher |
|---|---|
| Status: | new → assigned |
Make that, I'll do that later.
comment:5 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:6 Changed 15 years ago by
Note: See
TracTickets for help on using
tickets.
Milestone post-1.0 deleted