Opened 7 years ago

Closed 6 years ago

Last modified 4 years ago

#9957 closed (fixed)

Feeds discard timezone information from pubdate

Reported by: urajat Owned by: ericholscher
Component: contrib.syndication Version: master
Severity: Keywords: atom rss feeds timezone
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: UI/UX:

Description

Changeset 8216 which fixed 7016 calculates the timezone offset with respect to the server timezone. Even if timezone information is already present in the pubdate field (i.e. the datetime.datetime object returned by item_pubdate already contains a tzinfo component), it is discarded. The attached patch checks pubdate for attached timezone information before calculating the offset.

Attachments (1)

feeds_timezone_check.diff (521 bytes) - added by urajat 7 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by urajat

comment:1 Changed 7 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:2 Changed 7 years ago by jacob

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 6 years ago by ericholscher

  • Needs tests set

Looks sane to me. Skips the timezone creation magic when it already exists.

Needs tests. I'll do that now.

comment:4 Changed 6 years ago by ericholscher

  • Owner changed from nobody to ericholscher
  • Status changed from new to assigned

Make that, I'll do that later.

comment:5 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10435]) Fixed #9957: feeds now respect time zone information provided by the pub date.

comment:6 Changed 6 years ago by jacob

(In [10436]) [1.0.X] Fixed #9957: feeds now respect time zone information provided by the pub date. Backport of r10435 from trunk.

comment:7 Changed 4 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top