Opened 8 years ago

Closed 7 years ago

Last modified 5 years ago

#9948 closed (fixed)

URLField accepts invalid domains

Reported by: Ivan Giuliani Owned by: nobody
Component: Forms Version: 1.0
Severity: Keywords: urlfield hyphen
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

URLField accepts invalid domains like gmail-.com or dom------ain.com (it's basically the same problem of #9890).

Attachments (1)

urlfield-r9692.diff (1.7 KB) - added by Ivan Giuliani 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Ivan Giuliani

Attachment: urlfield-r9692.diff added

comment:1 Changed 8 years ago by Jacob

milestone: 1.1
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 7 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [10574]) Fixed #9948 -- Corrected URLField validation to match RFC1035 (URL analog of #9890). Thanks to kratorius for the report and fix.

comment:3 Changed 7 years ago by Russell Keith-Magee

(In [10577]) [1.0.X] Fixed #9948 -- Corrected URLField validation to match RFC1035 (URL analog of #9890). Thanks to kratorius for the report and fix.

Merge of r10574 from trunk.

comment:4 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top