Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9882 closed (fixed)

ModelForm.save() method must have alters_data=True

Reported by: dc Owned by: nobody
Component: Uncategorized Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation:
Needs tests: Patch needs improvement:
Easy pickings: UI/UX:

Description

Model.save() method has alters_data=True but ModelForm.save() has not. But it has side effects and can be called from templates. Thats also correct for ModelFormSets.

Change History (2)

comment:1 Changed 7 years ago by gwilson

  • Resolution set to fixed
  • Status changed from new to closed

(In [9678]) Fixed #9882 -- Added alters_data = True to BaseModelForm.save method, thanks dc.

comment:2 Changed 7 years ago by gwilson

(In [9679]) [1.0.X] Fixed #9882 -- Added alters_data = True to BaseModelForm.save method, thanks dc.

Backport of r9678 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top