Code

Opened 6 years ago

Closed 17 months ago

#9800 closed New feature (fixed)

Syndication Framework could implement isPermaLink": "false" to better follow the recommendations of the RSS Advisory Board

Reported by: martin <martin@…> Owned by: nobody
Component: contrib.syndication Version: master
Severity: Normal Keywords:
Cc: creecode, mpessas@…, rtnpro, charette.s@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

http://www.rssboard.org/rss-profile-1#element-channel-item-guid

RSS feeds should include a guid:isPermaLink": "false" element when the guid is not a permalink.

Otherwise if guid is not a link and item's link are not unique. RSS isn't valid.

Take a look here: http://www.hoboes.com/Mimsy/?ART=669

Attachments (3)

rss-add-isPermaLink-element.diff (709 bytes) - added by akoha 5 years ago.
Here's the patch.
rss-guid_is_permalink-attribute.diff (2.2 KB) - added by andreiko 4 years ago.
my version of patch
support_is_permalink_attr_in_rss_guid.patch (3.3 KB) - added by rtnpro 18 months ago.
Support 'isPermalink' attribute in <guid> element for an item in RSS feed.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 5 years ago by jacob

  • milestone set to 1.1
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Changed 5 years ago by akoha

Here's the patch.

comment:2 Changed 5 years ago by julianb

  • Has patch set

comment:3 Changed 5 years ago by jacob

  • Resolution set to wontfix
  • Status changed from new to closed

Unfortunately, we can't know just from the guid/link whether it is in fact a valid permalink or not. So this patch won't actually work for everyone. If you want validity, use Atom.

comment:4 Changed 4 years ago by andreiko

  • milestone changed from 1.1 to 1.3
  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Version changed from 1.0 to SVN

Here's another, more backward compatible solution — to let one specify "guid_is_permalink" attribute:

class Rss(Feed):
    title = "Chicagocrime.org site news"
    link = "http://chicagocrime.org/rss/"
    description = "Updates on changes and additions to chicagocrime.org."

    guid_is_permalink = False

Once it's specified, <guid> tags in the feed will have isPermalink attribute with appropriate value. If it isn't, isPermalink attribute is omitted.

Changed 4 years ago by andreiko

my version of patch

comment:5 Changed 4 years ago by ubernostrum

  • milestone 1.3 deleted

1.3 is feature-frozen now.

comment:6 Changed 3 years ago by lukeplant

  • Severity set to Normal
  • Type set to New feature

comment:7 Changed 3 years ago by aaugustin

  • Easy pickings unset
  • Needs documentation set
  • Needs tests set
  • Patch needs improvement set
  • UI/UX unset

Since the guid is a property of each item, the fact that it's a permalink should be passed somehow in the item description (the item argument of add_item_elements) rather than in the feed's constructor.

comment:8 Changed 3 years ago by creecode

  • Cc creecode added

comment:9 Changed 18 months ago by mpessas

  • Cc mpessas@… added

comment:10 Changed 18 months ago by rtnpro

  • Cc rtnpro added

Added support for 'isPermalink' attribute in a <guid> element for an item in an RSS feed.

https://github.com/django/django/pull/653/.

Changed 18 months ago by rtnpro

Support 'isPermalink' attribute in <guid> element for an item in RSS feed.

comment:11 Changed 18 months ago by charettes

  • Cc charette.s@… added
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Accepted to Ready for checkin

Patch at github includes doc and tests that passes on Python 2.7.3 and 3.2.3 with SQLite.

Marking as RFC.

comment:12 Changed 18 months ago by rtnpro

ping?

comment:13 Changed 17 months ago by Simon Charette <charette.s@…>

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5449240c548bb6877923791d02e800c6b25393f5:

Fixed #9800 -- Allow "isPermaLink" attribute in <guid> element of an RSS item.

Thanks @rtnpro for the patch!

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.