Opened 6 years ago

Closed 6 years ago

Last modified 2 years ago

#9797 closed (fixed)

.count() should use aggregates internally

Reported by: Alex Owned by:
Component: Database layer (models, ORM) Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

count() should use the aggregate facilites internally in order to not duplicate logic.

this is filed against the external aggregates branch

Attachments (3)

annotate-count.diff (1.9 KB) - added by Alex 6 years ago.
this fails with both dates and values
annotate-count.2.diff (3.6 KB) - added by Alex 6 years ago.
now only fails on 3 tests
annotate-count.3.diff (3.6 KB) - added by Alex 6 years ago.
All tests pass, logic is a bit of a clusterfuck, but it's mostly in the right place

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Alex

this fails with both dates and values

Changed 6 years ago by Alex

now only fails on 3 tests

Changed 6 years ago by Alex

All tests pass, logic is a bit of a clusterfuck, but it's mostly in the right place

comment:1 Changed 6 years ago by russellm

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to fixed
  • Status changed from new to closed

Resolved in aggregates Github branch, commit 76d45025bef067c78434edb477fe6621990c3468.

comment:2 Changed 2 years ago by akaariai

  • Component changed from ORM aggregation to Database layer (models, ORM)
Note: See TracTickets for help on using tickets.
Back to Top