Opened 15 years ago

Closed 15 years ago

Last modified 11 years ago

#9797 closed (fixed)

.count() should use aggregates internally

Reported by: Alex Gaynor Owned by:
Component: Database layer (models, ORM) Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

count() should use the aggregate facilites internally in order to not duplicate logic.

this is filed against the external aggregates branch

Attachments (3)

annotate-count.diff​ (1.9 KB ) - added by Alex Gaynor 15 years ago.
this fails with both dates and values
annotate-count.2.diff​ (3.6 KB ) - added by Alex Gaynor 15 years ago.
now only fails on 3 tests
annotate-count.3.diff​ (3.6 KB ) - added by Alex Gaynor 15 years ago.
All tests pass, logic is a bit of a clusterfuck, but it's mostly in the right place

Download all attachments as: .zip

Change History (5)

by Alex Gaynor, 15 years ago

Attachment: annotate-count.diff​ added

this fails with both dates and values

by Alex Gaynor, 15 years ago

Attachment: annotate-count.2.diff​ added

now only fails on 3 tests

by Alex Gaynor, 15 years ago

Attachment: annotate-count.3.diff​ added

All tests pass, logic is a bit of a clusterfuck, but it's mostly in the right place

comment:1 by Russell Keith-Magee, 15 years ago

Resolution: → fixed
Status: new → closed

Resolved in aggregates Github branch, commit 76d45025bef067c78434edb477fe6621990c3468.

comment:2 by Anssi Kääriäinen, 11 years ago

Component: ORM aggregation → Database layer (models, ORM)
Note: See TracTickets for help on using tickets.
Back to Top