Code

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#9792 closed (fixed)

Comments error form has malformed HTML

Reported by: Robert Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the comments preview.html template, a UL element is surrounded by a P tag, which is invalid HTML and doesn't display properly in FF3. Changing the surrounding element from a P to a DIV makes it work correctly. The screenshot is using Blueprint CSS, which makes the bug very noticeable.

I've attached an incredibly small patch and a screenshot of the bug.

Attachments (3)

comments_preview.diff (746 bytes) - added by Robert 5 years ago.
Patch to fix comments preview.html
redboxes.jpg (45.0 KB) - added by Robert 5 years ago.
Screenshot of comments preview.html bug
9792.diff (1.4 KB) - added by izibi 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by Robert

Patch to fix comments preview.html

Changed 5 years ago by Robert

Screenshot of comments preview.html bug

comment:1 Changed 5 years ago by izibi

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I think the error list should be before the <p>-tag as like the forms framework does when using as_p().

Changed 5 years ago by izibi

comment:2 Changed 5 years ago by jacob

  • milestone set to 1.1
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [10420]) Fixed #9792: corrected invalid HTML in the comment form and comment preview.

comment:4 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.