#9792 closed (fixed)
Comments error form has malformed HTML
| Reported by: | Robert | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.comments | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In the comments preview.html template, a UL element is surrounded by a P tag, which is invalid HTML and doesn't display properly in FF3. Changing the surrounding element from a P to a DIV makes it work correctly. The screenshot is using Blueprint CSS, which makes the bug very noticeable.
I've attached an incredibly small patch and a screenshot of the bug.
Attachments (3)
Change History (7)
by , 15 years ago
| Attachment: | comments_preview.diff added |
|---|
comment:1 by , 15 years ago
I think the error list should be before the <p>-tag as like the forms framework does when using as_p().
by , 15 years ago
comment:2 by , 15 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Patch to fix comments preview.html