Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#9792 closed (fixed)

Comments error form has malformed HTML

Reported by: Robert Owned by: nobody
Component: contrib.comments Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the comments preview.html template, a UL element is surrounded by a P tag, which is invalid HTML and doesn't display properly in FF3. Changing the surrounding element from a P to a DIV makes it work correctly. The screenshot is using Blueprint CSS, which makes the bug very noticeable.

I've attached an incredibly small patch and a screenshot of the bug.

Attachments (3)

comments_preview.diff (746 bytes ) - added by Robert 16 years ago.
Patch to fix comments preview.html
redboxes.jpg (45.0 KB ) - added by Robert 16 years ago.
Screenshot of comments preview.html bug
9792.diff (1.4 KB ) - added by izibi 16 years ago.

Download all attachments as: .zip

Change History (7)

by Robert, 16 years ago

Attachment: comments_preview.diff added

Patch to fix comments preview.html

by Robert, 16 years ago

Attachment: redboxes.jpg added

Screenshot of comments preview.html bug

comment:1 by izibi, 16 years ago

I think the error list should be before the <p>-tag as like the forms framework does when using as_p().

by izibi, 16 years ago

Attachment: 9792.diff added

comment:2 by Jacob, 16 years ago

milestone: 1.1
Triage Stage: UnreviewedAccepted

comment:3 by Jacob, 16 years ago

Resolution: fixed
Status: newclosed

(In [10420]) Fixed #9792: corrected invalid HTML in the comment form and comment preview.

comment:4 by Jacob, 13 years ago

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top