Code

Opened 6 years ago

Closed 6 years ago

#9748 closed (fixed)

r9550 broke modeladmin test

Reported by: kmtracey Owned by: nobody
Component: Uncategorized Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The buildbot (http://buildbot.djangoproject.com/waterfall) shows that the trunk tests have been failing since build 142, which was r9550 (fix #8248 -- make help() work on models with ForeignKeyFields). Here's the failure:

======================================================================
FAIL: Doctest: regressiontests.modeladmin.models.__test__.API_TESTS
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbots/slave/parts/ubuntu-feisty-python2.5-sqlite/django-trunk_ubuntu-feisty-python2.5-sqlite/build/django/test/_doctest.py", line 2180, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for regressiontests.modeladmin.models.__test__.API_TESTS
  File "/home/buildbots/slave/parts/ubuntu-feisty-python2.5-sqlite/django-trunk_ubuntu-feisty-python2.5-sqlite/build/tests/regressiontests/modeladmin/models.py", line unknown line number, in API_TESTS

----------------------------------------------------------------------
File "/home/buildbots/slave/parts/ubuntu-feisty-python2.5-sqlite/django-trunk_ubuntu-feisty-python2.5-sqlite/build/tests/regressiontests/modeladmin/models.py", line ?, in regressiontests.modeladmin.models.__test__.API_TESTS
Failed example:
    validate(ValidationTestModelAdmin, ValidationTestModel)
Expected:
    Traceback (most recent call last):
    ...
    ImproperlyConfigured: 'ValidationTestModelAdmin.list_display[0]', 'users' is a ManyToManyField which is not supported.
Got nothing


----------------------------------------------------------------------
Ran 547 tests in 906.302s

FAILED (failures=1)
Destroying test database...
program finished with exit code 1

It's not necessary to run the whole suite to get the failure, running just modeladmin is sufficient.

Attachments (0)

Change History (1)

comment:1 Changed 6 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [9563].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.