Custom Model.save() don't change relational data when editing via admin (probably any other forms too)
|Reported by:||anonymous||Owned by:||nobody|
|Has patch:||no||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
Consider following models:
class A(models.Model): name = models.CharField(max_length = 100) class B(models.Model): name = models.CharField(max_length = 100) related = models.ForeignKey(to = A, null = True, blank = True) def save(self): if not self.name.startswith('@'): self.name = '@' + self.name # this will work always if self.related and self.related.name.startswith('@'): self.related = None # won't work when editing via admin form super(B, self).save()
This illustrates that submitting the data via admin interface will always override relational changes in the custom Model.save() method. Other fields, however, are changed as expected.
Calling save() under some other circumstances will always change relational data as expected.
Any glue how to fix it? Thanks.
Change History (5)
comment:1 Changed 7 years ago by anonymous
- Component changed from Uncategorized to Forms
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
comment:2 Changed 7 years ago by jacob
- milestone set to 1.1
- Triage Stage changed from Unreviewed to Accepted
comment:4 Changed 6 years ago by jkocherhans
- Resolution set to worksforme
- Status changed from new to closed