Opened 16 years ago
Closed 16 years ago
#9652 closed (fixed)
base.css is not loaded in admin index.html
Reported by: | zhaoz | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Due to change in [source:django/trunk/contrib/admin/media/css/dashboard.css#9463] base.css is no longer being imported in dashboard.css.
However, [source:django/tags/releases/1.0.2/django/contrib/admin/templates/admin/index.html] overrides stylesheet instead of extrastyle.
This is fixed in trunk, but the relased 1.0.2 version has this bug.
Change History (5)
comment:1 by , 16 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
comment:2 by , 16 years ago
Resolution: | invalid |
---|---|
Status: | closed → reopened |
Version: | 1.0 → SVN |
The latest SVN (version 1.1.0 alpha) is missing the @import url('base.css') in the following files: dashboard.css, changelists.css, forms.css, login.css
comment:3 by , 16 years ago
Resolution: | → invalid |
---|---|
Status: | reopened → closed |
The removal of the import in these files was intentional, see: http://code.djangoproject.com/changeset/9463
Part of that commit message says "Each individual stylesheet is now linked to explicitly from the template where it's used" -- do you have an instance where this is not happening and therefore causes a problem? If so you need to point it out more specifically, because saying the @import is missing is not, in and of itself, a problem. It's just different from the way it used to be done.
comment:4 by , 16 years ago
Resolution: | invalid |
---|---|
Status: | closed → reopened |
crapufish: If you're like me, then the problem is caused by your overridden admin templates (after installing django-filebrowser, for instance). You have to update the CSS imports in your custom templates to follow the changes in [9463].
comment:5 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Sorry, didn't mean to reopen.
I don't understand. dashboard.css on the 1.0.X branch (and in the 1.0.2 release) hasn't changed in 3 years and does import base.css:
http://code.djangoproject.com/browser/django/tags/releases/1.0.2/django/contrib/admin/media/css/dashboard.css
None of the css reorganization that has been done recently has been backported to the 1.0.X branch, as it is not strictly bug-fixing. It rather sounds like you have installed 1.0.2 on top of a trunk checkout or something, and so have a mishmash of both.