Opened 8 years ago

Closed 8 years ago

#9652 closed (fixed)

base.css is not loaded in admin index.html

Reported by: zhaoz Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Due to change in [source:django/trunk/contrib/admin/media/css/dashboard.css#9463] base.css is no longer being imported in dashboard.css.

However, [source:django/tags/releases/1.0.2/django/contrib/admin/templates/admin/index.html] overrides stylesheet instead of extrastyle.

This is fixed in trunk, but the relased 1.0.2 version has this bug.

Change History (5)

comment:1 Changed 8 years ago by Karen Tracey

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Resolution: invalid
Status: newclosed

I don't understand. dashboard.css on the 1.0.X branch (and in the 1.0.2 release) hasn't changed in 3 years and does import base.css:

None of the css reorganization that has been done recently has been backported to the 1.0.X branch, as it is not strictly bug-fixing. It rather sounds like you have installed 1.0.2 on top of a trunk checkout or something, and so have a mishmash of both.

comment:2 Changed 8 years ago by crapufish

Resolution: invalid
Status: closedreopened
Version: 1.0SVN

The latest SVN (version 1.1.0 alpha) is missing the @import url('base.css') in the following files: dashboard.css, changelists.css, forms.css, login.css

comment:3 Changed 8 years ago by Karen Tracey

Resolution: invalid
Status: reopenedclosed

The removal of the import in these files was intentional, see:

Part of that commit message says "Each individual stylesheet is now linked to explicitly from the template where it's used" -- do you have an instance where this is not happening and therefore causes a problem? If so you need to point it out more specifically, because saying the @import is missing is not, in and of itself, a problem. It's just different from the way it used to be done.

comment:4 Changed 8 years ago by hanksims

Resolution: invalid
Status: closedreopened

crapufish: If you're like me, then the problem is caused by your overridden admin templates (after installing django-filebrowser, for instance). You have to update the CSS imports in your custom templates to follow the changes in [9463].

comment:5 Changed 8 years ago by hanksims

Resolution: fixed
Status: reopenedclosed

Sorry, didn't mean to reopen.

Note: See TracTickets for help on using tickets.
Back to Top