#9609 closed (fixed)
(Null)BooleanField does not clean data correctly for MySQL with all widgets
| Reported by: | Peter Sagerson | Owned by: | nobody |
|---|---|---|---|
| Component: | Forms | Version: | 1.0 |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
MySQL represents boolean values as 0 and 1, as the BooleanField documentation warns. This is not an issue when using a NullBooleanSelect widget, as NullBooleanSelect translates between model values and arbitrary integers for use in a form. However, not all choice widgets do this and thus they rely on the model values matching the widget values in order to populate initial widget state for rendering. The form field, in turn, must be able to clean the resulting form values. In order to support MySQL, therefore, (Null)BooleanField must understand '0' and '1'.
Ticket 7753 added support for using HiddenWidget with the boolean fields, which addresses the general problem of cleaning raw form values. The attached patch adds '0' and '1' to the list of recognized values.
Attachments (1)
Change History (6)
by , 15 years ago
| Attachment: | mysql_compat.diff added |
|---|
comment:1 by , 15 years ago
| Component: | Uncategorized → Forms |
|---|---|
| Version: | SVN → 1.0 |
comment:2 by , 15 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
comment:3 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 by , 15 years ago
(In [10662]) Fixed #9609 -- Modified the clean method of(Null)Boolean field to accept '1' and '0' as valid inputs. Thanks to psagers for the patch.
This is required to support the use of non-default form widgets such as RadioSelect when the data comes from MySQL, which uses 1/0 to represent booleans.
Merge of r10660 from trunk.
(In [10660]) Fixed #9609 -- Modified the clean method of(Null)Boolean field to accept '1' and '0' as valid inputs. Thanks to psagers for the patch.
This is required to support the use of non-default form widgets such as RadioSelect when the data comes from MySQL, which uses 1/0 to represent booleans.