Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#9591 closed (fixed)

MemoryFileUploadHandler doesn't rewind InMemoryUploadedFile to the beginning

Reported by: Ivan Sagalaev Owned by: nobody
Component: File uploads/storage Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

MemoryFileUploadHandler creates an InMemoryUploadedFile and passes it to storage.save without doing seek(0) beforehand. This contradicts the docstring of storage.save that says "The content should be a proper File object, ready to be read from the beginning."

Patch follows.

P.S. Uploaded files are saved correctly though with the standard FileSystemStorage because it uses .chunks() method of a File object that incidentally does seek(0) before read().

Attachments (2)

9591.diff (399 bytes) - added by Ivan Sagalaev 8 years ago.
Patch
9591-test.diff (2.2 KB) - added by mmarshall 8 years ago.
Simple test

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Ivan Sagalaev

Attachment: 9591.diff added

Patch

comment:1 Changed 8 years ago by Ivan Giuliani

Component: UncategorizedFile uploads/storage

comment:2 Changed 8 years ago by Jacob

milestone: 1.1
Triage Stage: UnreviewedAccepted

comment:3 Changed 8 years ago by Bob Thomas

Has patch: set

comment:4 Changed 8 years ago by mmarshall

Resolution: fixed
Status: newclosed

This appears to be fixed. InMemoryUploadFile.init calls seek(0) on the file.

Changed 8 years ago by mmarshall

Attachment: 9591-test.diff added

Simple test

comment:5 Changed 5 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top