javascript_quote should accept SafeUnicode

[boyerchen@…]

django.utils.javascript_quote does not accept a SafeUnicode instance as argument and raises a TypeError.

Expected behavior:
Treat SafeUnicode as usual unicode string.

[Keith Bussell]

django.utils is for tools internal to Django, and nothing at this layer currently knows about safe strings.

How are you using this function? Note: If you're calling this from a template, you can use django.template.defaultfilters.escapejs.

[Passy]

I used it to escape a rendered form in an ajax response to load it afterwards into a wrapper element with javascript. I currently decode it as UTF-8, but I guess supporting a safe string would be more intuitive.

[Keith Bussell]

Replying to Passy:

I used it to escape a rendered form in an ajax response to load it afterwards into a wrapper element with javascript. I currently decode it as UTF-8, but I guess supporting a safe string would be more intuitive.

Use django.template.defaultfilters.escapejs instead of javascript_quote. (You don't need to limit use of template filters to template rendering. Filters are just functions that operate on strings, and safe strings.)

(resolution approved by Jacob)

[Jacob]

Milestone 1.1 deleted