Opened 8 years ago

Closed 6 years ago

#9568 closed (fixed)

admin/login.html should contain empty nav-global block

Reported by: Wayne K. Werner Owned by: nobody
Component: contrib.admin Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The admin/login.html template includes an empty 'breadcrumbs' block, to make sure that any breadcrumbs are suppressed. As the login form is presented in a small frame, much like a popup where breadcrumbs are also supressed, this seems reasonable.

However, while nav-global blocks are suppressed in popups (along with the entire header), they do however appear on the login dialog. This causes the login page to look strange, at the least, for anyone employing the nav-global block in a custom admin/base_site.html or admin/base.html.

Inserting {% block nav-global %}{% endblock %} near the empty breadcrumbs block would eliminate this eyesore.

I am doing so in a custom admin/login.html currently to deal with this, but I think this is probably an oversight in the 'real' admin/login.html. Understandable in that the nav-global block is probably rarely used.

Attachments (1)

login_template.diff (223 bytes) - added by Wayne K. Werner 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by Wayne K. Werner

Attachment: login_template.diff added

comment:1 Changed 8 years ago by Wayne K. Werner

Component: Uncategorizeddjango.contrib.admin
Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 8 years ago by Jacob

milestone: 1.1
Triage Stage: UnreviewedAccepted

comment:3 Changed 7 years ago by Jacob

milestone: 1.11.2

comment:4 Changed 7 years ago by James Bennett

milestone: 1.2

1.2 is feature-frozen, moving this feature request off the milestone.

comment:5 Changed 6 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

(In [14766]) Fixed #9568 -- Hide nav-global div in admin login template in case it's used admin/base_site.html or admin/base.html. Thanks, AmanKow.

Note: See TracTickets for help on using tickets.
Back to Top