Code

Opened 5 years ago

Closed 3 years ago

#9568 closed (fixed)

admin/login.html should contain empty nav-global block

Reported by: AmanKow Owned by: nobody
Component: contrib.admin Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The admin/login.html template includes an empty 'breadcrumbs' block, to make sure that any breadcrumbs are suppressed. As the login form is presented in a small frame, much like a popup where breadcrumbs are also supressed, this seems reasonable.

However, while nav-global blocks are suppressed in popups (along with the entire header), they do however appear on the login dialog. This causes the login page to look strange, at the least, for anyone employing the nav-global block in a custom admin/base_site.html or admin/base.html.

Inserting {% block nav-global %}{% endblock %} near the empty breadcrumbs block would eliminate this eyesore.

I am doing so in a custom admin/login.html currently to deal with this, but I think this is probably an oversight in the 'real' admin/login.html. Understandable in that the nav-global block is probably rarely used.

Attachments (1)

login_template.diff (223 bytes) - added by AmanKow 5 years ago.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by AmanKow

comment:1 Changed 5 years ago by AmanKow

  • Component changed from Uncategorized to django.contrib.admin
  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 5 years ago by jacob

  • milestone set to 1.1
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 5 years ago by jacob

  • milestone changed from 1.1 to 1.2

comment:4 Changed 4 years ago by ubernostrum

  • milestone 1.2 deleted

1.2 is feature-frozen, moving this feature request off the milestone.

comment:5 Changed 3 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [14766]) Fixed #9568 -- Hide nav-global div in admin login template in case it's used admin/base_site.html or admin/base.html. Thanks, AmanKow.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.