Python serializer doesn't use base Serializer.get_string_value

[Alexander Koshelev]

Just now python serializer in handle_field simple call getattr to retrieve field value form the object:

smart_unicode(getattr(obj, field.name), strings_only=True)

And base Serializer has method get_string_value that calls appropriate value_to_string field method but derived serializers doesn't call it at all.

It causes problem than model has non-string field that cannot simply be converted to string.

[Russell Keith-Magee]

Quick and dirty is fine, but you're not going to convince me to apply the patch without a test case - ideally, something integrated into the Django test suite, but at the very least, a model definition and python session that demonstrates the problem.

[Alexander Koshelev]

Yes, first attempt was not good. I've made some more changes and written the tests.

[Alexander Koshelev]

new patch with tests

[Axel Hecht]

I'm getting hit by this, too.

I found that the DeSerialization calls into to_python [1], so I wonder if the Serialization shouldn't just call into get_db_prep_save.

Or is it a safe assumption that feeding a string into to_python is always going to succeed?

[1] ​http://code.djangoproject.com/browser/django/trunk/django/core/serializers/python.py#L88

[(none)]

Milestone post-1.0 deleted

[Christian Hammond]

Are there any plans to get this in? It's proving to be a real problem for me. After some Googling, it seems several people are patching their Django sources to work around this.

[Eric Holscher]

This patch is adding a value to every model in Django. I don't think this is the correct implementation. Models know nothing about serialization, and if we're going to start adding serialization information to them, we're going to need to have a much bigger discussion about it.

This change should be contained to the serializers, perhaps with a third party serializer that provides the functionality. Something along the lines of ./manage.py dumpdata --full-serialize=ModelName perhaps.

[Alexander Koshelev]

Oh, where do you find "adding value to every model"? Patch doesn't do it at all. It only adds flag attribute to model *field* and field already knows how to convert it to string. And this knowledge is used in serializers just now.

[Russell Keith-Magee]

(In [10554]) Fixed #9522 -- Modified handling of values in base serializer so that field subclasses can define their own value_to_string() method for serialization. Thanks to Alex Koshelev for the report and initial patch.

[Russell Keith-Magee]

(In [10555]) [1.0.X] Fixed #9522 -- Modified handling of values in base serializer so that field subclasses can define their own value_to_string() method for serialization. Thanks to Alex Koshelev for the report and initial patch.

Merge of r10554 from trunk.

[Jacob]

Milestone 1.1 deleted