Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9506 closed (fixed)

Missing i18n string in django.contrib.admin.options

Reported by: petar Owned by: kmtracey
Component: Internationalization Version: master
Severity: Keywords: i18n
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Source line 559:
raise Http404('%s object with primary key %r does not exist.' % (force_unicode(opts.verbose_name), escape(object_id)))

Expected:
raise Http404(_('%s object with primary key %r does not exist.') % (force_unicode(opts.verbose_name), escape(object_id)))

Attachments (1)

9506_1.0.1.diff (714 bytes) - added by telenieko 7 years ago.
Patch

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by telenieko

Patch

comment:1 Changed 7 years ago by telenieko

  • Component changed from Translations to Internationalization
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Patch attached, please commit ASAP to have translations in time for 1.0.1 if possible ;)

comment:2 Changed 7 years ago by kmtracey

  • Resolution set to fixed
  • Status changed from new to closed

(In [9360]) Fixed #9506 -- Marked error string for translation.

comment:3 Changed 7 years ago by kmtracey

(In [9362]) [1.0.X] Fixed #9506 -- Marked error string for translation.

[9360] from trunk.

comment:4 Changed 7 years ago by zgoda

  • Resolution fixed deleted
  • Status changed from closed to reopened

The convention used in this patch prevents locale catalog updating:

jarek:~/install/django/django$ LANG=C django-admin.py makemessages -l pl
processing language pl
Error: errors happened while running xgettext on options.py
./contrib/admin/options.py:559: warning: 'msgid' format string with unnamed arguments cannot be properly localized:
                                         The translator cannot reorder the arguments.
                                         Please consider using a format string with named arguments,
                                         and a mapping instead of a tuple for the arguments.

comment:5 Changed 7 years ago by kmtracey

  • Owner changed from nobody to kmtracey
  • Status changed from reopened to new

Oops. I'll fix it.

comment:6 Changed 7 years ago by kmtracey

  • Resolution set to fixed
  • Status changed from new to closed

(In [9363]) Fixed #9506 take 2 -- Marked the message properly for translation, in both places it appears in the source.

comment:7 Changed 7 years ago by kmtracey

(In [9364]) [1.0.X] Fixed #9506 take 2 -- Marked the message properly for translation, in both places it appears in the source.

[9363] from trunk.

comment:8 Changed 7 years ago by ramiro

(In [9421]) [1.0.X] Updated Argentinian spanish translations, refs #9506 and related commits.

Port of [9420] from trunk.

Note: See TracTickets for help on using tickets.
Back to Top