Opened 8 years ago

Closed 8 years ago

#9408 closed (wontfix)

Oracle backend, error in FormatStylePlaceholderCursor _format_params method

Reported by: Ramiro Morales Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords: oracle _format_params
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by Ramiro Morales)

This was reported in passing in the #5543 attachment comment but it can be fixed independently so I'm reporting it here just in case it's a real problem.

Attachments (1)

t9408.diff (593 bytes) - added by Ramiro Morales 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by Ramiro Morales

Description: modified (diff)

Changed 8 years ago by Ramiro Morales

Attachment: t9408.diff added

comment:2 Changed 8 years ago by Ramiro Morales

Description: modified (diff)
Summary: Oracle backend, error in Oracle's FormatStylePlaceholderCursor _format_params methodOracle backend, error in FormatStylePlaceholderCursor _format_params method
Version: 1.0SVN

comment:3 Changed 8 years ago by Ian Kelly

Is there a use case for fixing this? My preference at this point is to remove the support for passing params as a dictionary altogether.

That this typo hasn't been pointed out before suggests that nobody is actually using it. The Django documentation explicitly says to pass the params for raw queries as a list. It's not even a useful feature since the dictionary keys would have to be 'arg0', 'arg1', etc. Removing it would not be backwards-incompatible since the feature doesn't even work in the first place.

comment:4 Changed 8 years ago by Matt Boersma

I agree with ikelly--we should remove the dict support here since it's undocumented and troublesome.

comment:5 Changed 8 years ago by Ian Kelly

(In [9418]) Refs #9408: Removed support for passing params as dicts in the oracle backend. Wasn't documented, didn't work, isn't necessary.

comment:6 Changed 8 years ago by Ian Kelly

Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.
Back to Top