Code

Opened 6 years ago

Closed 6 years ago

#9408 closed (wontfix)

Oracle backend, error in FormatStylePlaceholderCursor _format_params method

Reported by: ramiro Owned by: nobody
Component: Database layer (models, ORM) Version: master
Severity: Keywords: oracle _format_params
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by ramiro)

This was reported in passing in the #5543 attachment comment but it can be fixed independently so I'm reporting it here just in case it's a real problem.

Attachments (1)

t9408.diff (593 bytes) - added by ramiro 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by ramiro

  • Description modified (diff)
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Changed 6 years ago by ramiro

comment:2 Changed 6 years ago by ramiro

  • Description modified (diff)
  • Summary changed from Oracle backend, error in Oracle's FormatStylePlaceholderCursor _format_params method to Oracle backend, error in FormatStylePlaceholderCursor _format_params method
  • Version changed from 1.0 to SVN

comment:3 Changed 6 years ago by ikelly

Is there a use case for fixing this? My preference at this point is to remove the support for passing params as a dictionary altogether.

That this typo hasn't been pointed out before suggests that nobody is actually using it. The Django documentation explicitly says to pass the params for raw queries as a list. It's not even a useful feature since the dictionary keys would have to be 'arg0', 'arg1', etc. Removing it would not be backwards-incompatible since the feature doesn't even work in the first place.

comment:4 Changed 6 years ago by mboersma

I agree with ikelly--we should remove the dict support here since it's undocumented and troublesome.

comment:5 Changed 6 years ago by ikelly

(In [9418]) Refs #9408: Removed support for passing params as dicts in the oracle backend. Wasn't documented, didn't work, isn't necessary.

comment:6 Changed 6 years ago by ikelly

  • Resolution set to wontfix
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.