Opened 16 years ago
Closed 16 years ago
#9408 closed (wontfix)
Oracle backend, error in FormatStylePlaceholderCursor _format_params method
| Reported by: | Ramiro Morales | Owned by: | nobody |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Keywords: | oracle _format_params | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
This was reported in passing in the #5543 attachment comment but it can be fixed independently so I'm reporting it here just in case it's a real problem.
Attachments (1)
Change History (7)
comment:1 by , 16 years ago
| Description: | modified (diff) |
|---|
by , 16 years ago
| Attachment: | t9408.diff added |
|---|
comment:2 by , 16 years ago
| Description: | modified (diff) |
|---|---|
| Summary: | Oracle backend, error in Oracle's FormatStylePlaceholderCursor _format_params method → Oracle backend, error in FormatStylePlaceholderCursor _format_params method |
| Version: | 1.0 → SVN |
comment:3 by , 16 years ago
comment:4 by , 16 years ago
I agree with ikelly--we should remove the dict support here since it's undocumented and troublesome.
comment:5 by , 16 years ago
comment:6 by , 16 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Is there a use case for fixing this? My preference at this point is to remove the support for passing params as a dictionary altogether.
That this typo hasn't been pointed out before suggests that nobody is actually using it. The Django documentation explicitly says to pass the params for raw queries as a list. It's not even a useful feature since the dictionary keys would have to be 'arg0', 'arg1', etc. Removing it would not be backwards-incompatible since the feature doesn't even work in the first place.