Opened 7 years ago

Closed 6 years ago

#9326 closed (fixed)

permalink decorator used in doc and then pre-decorator method used without notice.

Reported by: bartek Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Just a small thing but..

Page: http://docs.djangoproject.com/en/dev/ref/models/instances/#django.db.models.permalink

Confused me for a bit because there is no mention as to why all of a sudden the doc uses the pre-decorator method of:
get_absolute_url = permalink(get_absolute_url)

Would be nice to have it fully switched to using a decorator or put a note "For python 2.3 or earlier, use this:"

I hope this hasn't been submitted before :)

Attachments (1)

9326.diff (533 bytes) - added by timo 6 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 7 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Changed 6 years ago by timo

comment:2 Changed 6 years ago by timo

  • Has patch set
  • Triage Stage changed from Accepted to Ready for checkin
  • Version changed from 1.0 to SVN

since python 2.3 isn't support in the development version, this patch converts that instance to the decorator that's used everywhere else

comment:3 Changed 6 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

(In [12222]) Fixed #9326 - Use decorator syntax in get_absolute_url example. Thanks, timo.

Note: See TracTickets for help on using tickets.
Back to Top