Opened 8 years ago

Closed 5 years ago

#9316 closed Bug (wontfix)

databrowse does not filter URL fields properly

Reported by: ishirav Owned by: nobody
Component: contrib.databrowse Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

When trying to filter results by a field that contains a URL, the link generated by databrowse is invalid.

For example, I have a visit tracking application, and each visit has a referrer URLField.
So when I go to http://mysite.com/databrowse/visitors/visit/fields/referrer/ I see a list of all the different values for referrer (so far so good).
But when I click on one of them such as http://mysite.com/accounts/login/, the browser goes to http://mysite.com/accounts/login// (notice the double slash at the end) instead of the expected http://mysite.com/databrowse/visitors/visit/fields/referrer/{{ the referrer URL }}/

Attachments (1)

databrowse-encode-strings.diff (7.5 KB) - added by Adam Vandenberg 6 years ago.
Preliminary patch.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by Jacob

Triage Stage: UnreviewedAccepted

Changed 6 years ago by Adam Vandenberg

Preliminary patch.

comment:2 Changed 6 years ago by Adam Vandenberg

Has patch: set
Needs tests: set
Patch needs improvement: set
Version: 1.0SVN

Added a preliminary patch. The Admin site uses a custom quote function to ensure that URL parts don't get unencoded at the wrong time on various hosting solutions or browsers. I borrowed the quote/unquote functions from admin and are slotting them into databrowse in places where text fields are slotted into URL segments.

comment:3 Changed 6 years ago by Luke Plant

Severity: Normal
Type: Bug

comment:4 Changed 5 years ago by Preston Holmes

Easy pickings: unset
Resolution: wontfix
Status: newclosed
UI/UX: unset

Databrowse is now deprecated, see #16907

Note: See TracTickets for help on using tickets.
Back to Top