Code

Opened 6 years ago

Closed 3 years ago

#9316 closed Bug (wontfix)

databrowse does not filter URL fields properly

Reported by: ishirav Owned by: nobody
Component: contrib.databrowse Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

When trying to filter results by a field that contains a URL, the link generated by databrowse is invalid.

For example, I have a visit tracking application, and each visit has a referrer URLField.
So when I go to http://mysite.com/databrowse/visitors/visit/fields/referrer/ I see a list of all the different values for referrer (so far so good).
But when I click on one of them such as http://mysite.com/accounts/login/, the browser goes to http://mysite.com/accounts/login// (notice the double slash at the end) instead of the expected http://mysite.com/databrowse/visitors/visit/fields/referrer/{{ the referrer URL }}/

Attachments (1)

databrowse-encode-strings.diff (7.5 KB) - added by adamv 4 years ago.
Preliminary patch.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 5 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Changed 4 years ago by adamv

Preliminary patch.

comment:2 Changed 4 years ago by adamv

  • Has patch set
  • Needs tests set
  • Patch needs improvement set
  • Version changed from 1.0 to SVN

Added a preliminary patch. The Admin site uses a custom quote function to ensure that URL parts don't get unencoded at the wrong time on various hosting solutions or browsers. I borrowed the quote/unquote functions from admin and are slotting them into databrowse in places where text fields are slotted into URL segments.

comment:3 Changed 3 years ago by lukeplant

  • Severity set to Normal
  • Type set to Bug

comment:4 Changed 3 years ago by ptone

  • Easy pickings unset
  • Resolution set to wontfix
  • Status changed from new to closed
  • UI/UX unset

Databrowse is now deprecated, see #16907

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.