Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#9303 closed (fixed)

comment templatetags should be independent of Comment model

Reported by: Thejaswi Puthraya Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords: comments, templatetags, independent, customize
Cc: Carl Meyer, halfdan@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The comment app templatetags should be independent of the Comment model. This is for the customizability of the comment app.

Attachments (3)

9303_hasattr.diff (819 bytes) - added by Thejaswi Puthraya 8 years ago.
First method that uses hasattr
9303_model.diff (2.0 KB) - added by Thejaswi Puthraya 8 years ago.
Second method that changes BaseCommentAbstractModel
9303.diff (909 bytes) - added by Thejaswi Puthraya 8 years ago.
git-patch against the latest checkout

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by Thejaswi Puthraya

Attachment: 9303_hasattr.diff added

First method that uses hasattr

Changed 8 years ago by Thejaswi Puthraya

Attachment: 9303_model.diff added

Second method that changes BaseCommentAbstractModel

comment:1 Changed 8 years ago by Thejaswi Puthraya

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 8 years ago by Carl Meyer

Cc: carl@… added

comment:3 Changed 8 years ago by Carl Meyer

Triage Stage: UnreviewedAccepted

comment:4 Changed 8 years ago by Carl Meyer

Cc: Carl Meyer added; carl@… removed

comment:5 Changed 8 years ago by Jacob

Resolution: fixed
Status: newclosed

(In [9891]) Fixed #9303: comment templatetags no longer assume the built-in comment model.

comment:6 Changed 8 years ago by halfdan

Cc: halfdan@… added

comment:7 Changed 8 years ago by Thejaswi Puthraya

milestone: 1.1 beta
Resolution: fixed
Status: closedreopened

This bug still exists because the filter on is_public is being tried even before the fieldnames are checked. Looks like this line was overlooked while being checked in...

This bug was identified in http://code.djangoproject.com/ticket/8630#comment:23.

Changed 8 years ago by Thejaswi Puthraya

Attachment: 9303.diff added

git-patch against the latest checkout

comment:8 Changed 8 years ago by Thejaswi Puthraya

Has patch: set

comment:9 Changed 8 years ago by Jacob

Resolution: fixed
Status: reopenedclosed

Fixed in [10109].

comment:10 Changed 5 years ago by Jacob

milestone: 1.1 beta

Milestone 1.1 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top