Code

Opened 6 years ago

Closed 5 years ago

Last modified 3 years ago

#9303 closed (fixed)

comment templatetags should be independent of Comment model

Reported by: thejaswi_puthraya Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords: comments, templatetags, independent, customize
Cc: carljm, halfdan@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The comment app templatetags should be independent of the Comment model. This is for the customizability of the comment app.

Attachments (3)

9303_hasattr.diff (819 bytes) - added by thejaswi_puthraya 6 years ago.
First method that uses hasattr
9303_model.diff (2.0 KB) - added by thejaswi_puthraya 6 years ago.
Second method that changes BaseCommentAbstractModel
9303.diff (909 bytes) - added by thejaswi_puthraya 5 years ago.
git-patch against the latest checkout

Download all attachments as: .zip

Change History (13)

Changed 6 years ago by thejaswi_puthraya

First method that uses hasattr

Changed 6 years ago by thejaswi_puthraya

Second method that changes BaseCommentAbstractModel

comment:1 Changed 6 years ago by thejaswi_puthraya

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 6 years ago by carljm

  • Cc carl@… added

comment:3 Changed 6 years ago by carljm

  • Triage Stage changed from Unreviewed to Accepted

comment:4 Changed 5 years ago by carljm

  • Cc carljm added; carl@… removed

comment:5 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [9891]) Fixed #9303: comment templatetags no longer assume the built-in comment model.

comment:6 Changed 5 years ago by halfdan

  • Cc halfdan@… added

comment:7 Changed 5 years ago by thejaswi_puthraya

  • milestone set to 1.1 beta
  • Resolution fixed deleted
  • Status changed from closed to reopened

This bug still exists because the filter on is_public is being tried even before the fieldnames are checked. Looks like this line was overlooked while being checked in...

This bug was identified in http://code.djangoproject.com/ticket/8630#comment:23.

Changed 5 years ago by thejaswi_puthraya

git-patch against the latest checkout

comment:8 Changed 5 years ago by thejaswi_puthraya

  • Has patch set

comment:9 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in [10109].

comment:10 Changed 3 years ago by jacob

  • milestone 1.1 beta deleted

Milestone 1.1 beta deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.