Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#9282 closed (fixed)

Inclusion of comment-utils moderator facility

Reported by: Thejaswi Puthraya Owned by: Jannis Leidel
Component: contrib.comments Version: dev
Severity: Keywords: spam filter, comments, comment-utils
Cc: semente@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

James Bennett's comment-utils spam filtering feature was part of the initial code I wrote for the comments refactor. But due to lack of time to document this feature and the comments-refactor making it in the last minute, this feature was dropped for a later stage.

I have removed all references to akismet. For incorporation with Akismet, they can easily subclass the moderator class and get it done or best, just download it off from the comment-utils site.

Jacob liked this idea and wanted it in after the comments refactor stabilized. I also want to know what the other core-devs and James' think about this.

Attachments (3)

9282.diff​ (18.7 KB ) - added by Thejaswi Puthraya 16 years ago.
svn-patch against latest checkout
9282.2.diff​ (33.9 KB ) - added by Thejaswi Puthraya 16 years ago.
git-patch against the latest checkout. Contains tests and docs. Thanks ubernostrum
comment-utils.r10029.diff​ (34.7 KB ) - added by Jannis Leidel 16 years ago.
Updated patch with sphinxified documentation

Download all attachments as: .zip

Change History (12)

by Thejaswi Puthraya, 16 years ago

Attachment: 9282.diff​ added

svn-patch against latest checkout

comment:1 by Thejaswi Puthraya, 16 years ago

Needs documentation: set
Triage Stage: Unreviewed → Design decision needed

For the documentation, James has a lot of docstrings that can be used as documentation. But let's wait and see what the core-devs think.

comment:2 by Jannis Leidel, 16 years ago

@thejaswi_puthraya Do you plan to work on this? Since if not I'd do it.. :)

by Thejaswi Puthraya, 16 years ago

Attachment: 9282.2.diff​ added

git-patch against the latest checkout. Contains tests and docs. Thanks ubernostrum

comment:3 by Thejaswi Puthraya, 16 years ago

Needs documentation: unset

comment:4 by Guilherme Gondim <semente@…>, 16 years ago

Cc: semente@… added

comment:5 by Jannis Leidel, 16 years ago

Owner: changed from nobody to Jannis Leidel
Status: new → assigned
Triage Stage: Design decision needed → Accepted

This feature is on the feature list for 1.1 and should therefor be triaged as accepted.

See also ​http://github.com/jezdez/django/tree/comment-utils for a git patch.

by Jannis Leidel, 16 years ago

Attachment: comment-utils.r10029.diff​ added

Updated patch with sphinxified documentation

comment:6 by Jannis Leidel, 16 years ago

milestone: → 1.1

comment:7 by Jannis Leidel, 16 years ago

milestone: 1.1 → 1.1 beta

comment:8 by Jacob, 16 years ago

Resolution: → fixed
Status: assigned → closed

(In [10122]) Fixed #9282: added a generic comment moderation toolkit. See the documentation for details.

This began life as (part of) James Bennett's comment-utils app, and was adapted to be part of Django by Thejaswi Puthraya and Jannis Leidel. Thanks, all!

comment:9 by Jacob, 13 years ago

milestone: 1.1 beta

Milestone 1.1 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top