Code

Opened 6 years ago

Closed 5 years ago

Last modified 3 years ago

#9282 closed (fixed)

Inclusion of comment-utils moderator facility

Reported by: thejaswi_puthraya Owned by: jezdez
Component: contrib.comments Version: master
Severity: Keywords: spam filter, comments, comment-utils
Cc: semente@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

James Bennett's comment-utils spam filtering feature was part of the initial code I wrote for the comments refactor. But due to lack of time to document this feature and the comments-refactor making it in the last minute, this feature was dropped for a later stage.

I have removed all references to akismet. For incorporation with Akismet, they can easily subclass the moderator class and get it done or best, just download it off from the comment-utils site.

Jacob liked this idea and wanted it in after the comments refactor stabilized. I also want to know what the other core-devs and James' think about this.

Attachments (3)

9282.diff (18.7 KB) - added by thejaswi_puthraya 6 years ago.
svn-patch against latest checkout
9282.2.diff (33.9 KB) - added by thejaswi_puthraya 5 years ago.
git-patch against the latest checkout. Contains tests and docs. Thanks ubernostrum
comment-utils.r10029.diff (34.7 KB) - added by jezdez 5 years ago.
Updated patch with sphinxified documentation

Download all attachments as: .zip

Change History (12)

Changed 6 years ago by thejaswi_puthraya

svn-patch against latest checkout

comment:1 Changed 6 years ago by thejaswi_puthraya

  • Needs documentation set
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

For the documentation, James has a lot of docstrings that can be used as documentation. But let's wait and see what the core-devs think.

comment:2 Changed 5 years ago by jezdez

@thejaswi_puthraya Do you plan to work on this? Since if not I'd do it.. :)

Changed 5 years ago by thejaswi_puthraya

git-patch against the latest checkout. Contains tests and docs. Thanks ubernostrum

comment:3 Changed 5 years ago by thejaswi_puthraya

  • Needs documentation unset

comment:4 Changed 5 years ago by Guilherme Gondim <semente@…>

  • Cc semente@… added

comment:5 Changed 5 years ago by jezdez

  • Owner changed from nobody to jezdez
  • Status changed from new to assigned
  • Triage Stage changed from Design decision needed to Accepted

This feature is on the feature list for 1.1 and should therefor be triaged as accepted.

See also http://github.com/jezdez/django/tree/comment-utils for a git patch.

Changed 5 years ago by jezdez

Updated patch with sphinxified documentation

comment:6 Changed 5 years ago by jezdez

  • milestone set to 1.1

comment:7 Changed 5 years ago by jezdez

  • milestone changed from 1.1 to 1.1 beta

comment:8 Changed 5 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10122]) Fixed #9282: added a generic comment moderation toolkit. See the documentation for details.

This began life as (part of) James Bennett's comment-utils app, and was adapted to be part of Django by Thejaswi Puthraya and Jannis Leidel. Thanks, all!

comment:9 Changed 3 years ago by jacob

  • milestone 1.1 beta deleted

Milestone 1.1 beta deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.