Code

Opened 6 years ago

Closed 5 years ago

#9273 closed (invalid)

Breadcrumbs refactor in newforms-admin

Reported by: erny Owned by: nobody
Component: contrib.admin Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The code to create breadcrumbs is duplicated in all templates.

In index.html and app_index.html, app.name.title is used (with blocktrans which tries to translate "%(name)s", nonsense) , and application names can not be translated.

In change_form.html, change_list.html, delete_confirmation.html and object_list.html {{ app_label|capfirst|escape }} is used.

This is not DRY. Perhaps, breadcrumbs could be calculated in view functions and send to the templates within the context. There should be a way for the user to change the generated breadcrumbs.

Attachments (0)

Change History (1)

comment:1 Changed 5 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Resolution set to invalid
  • Status changed from new to closed

There isn't a specific action plan here, nor really a bug.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.