Opened 16 years ago
Closed 16 years ago
#9273 closed (invalid)
Breadcrumbs refactor in newforms-admin
Reported by: | erny | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | 1.0 |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Unreviewed | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The code to create breadcrumbs is duplicated in all templates.
In index.html and app_index.html, app.name.title is used (with blocktrans which tries to translate "%(name)s", nonsense) , and application names can not be translated.
In change_form.html, change_list.html, delete_confirmation.html and object_list.html {{ app_label|capfirst|escape }}
is used.
This is not DRY. Perhaps, breadcrumbs could be calculated in view functions and send to the templates within the context. There should be a way for the user to change the generated breadcrumbs.
There isn't a specific action plan here, nor really a bug.