Opened 8 years ago

Closed 7 years ago

#9223 closed (fixed)

Declarative widgets for ModelForm

Reported by: Ivan Sagalaev Owned by: nobody
Component: Forms Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Implementation of widgets attribute of inner Meta class of ModelForm. The whole (but short!) discussion is here: http://groups.google.com/group/django-developers/browse_frm/thread/f879f383870b92c1

Attachments (4)

9223.diff (5.8 KB) - added by Ivan Sagalaev 8 years ago.
Patch with test and docs
9223.2.diff (5.6 KB) - added by Ivan Sagalaev 8 years ago.
Patch correcting the bug with shared dict
9223.3.diff (5.6 KB) - added by Ivan Sagalaev 8 years ago.
Patch updated to current trunk
9223.4.diff (5.6 KB) - added by Ivan Sagalaev 7 years ago.
Patch updated to current trunk

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by Ivan Sagalaev

Attachment: 9223.diff added

Patch with test and docs

comment:1 Changed 8 years ago by Ivan Sagalaev

Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:2 Changed 8 years ago by Chris Beaven

Bug: You're sharing the kwargs dict, so it'll get applied to all following fields.

Changed 8 years ago by Ivan Sagalaev

Attachment: 9223.2.diff added

Patch correcting the bug with shared dict

comment:3 Changed 8 years ago by Ivan Sagalaev

Good catch, thanks! I've fixed the bug and added a test specifically for this issue.

comment:4 Changed 8 years ago by Jacob

Triage Stage: UnreviewedAccepted

Changed 8 years ago by Ivan Sagalaev

Attachment: 9223.3.diff added

Patch updated to current trunk

comment:5 Changed 7 years ago by Simon Litchfield

Triage Stage: AcceptedReady for checkin

This patch isn't present in rev 11440.

Changed 7 years ago by Ivan Sagalaev

Attachment: 9223.4.diff added

Patch updated to current trunk

comment:6 Changed 7 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [12194]) Fixed #9223 -- Added support for declarative widgets to ModelForm. I declare thanks to isagalaev.

Note: See TracTickets for help on using tickets.
Back to Top