Code

Opened 6 years ago

Closed 4 years ago

#9223 closed (fixed)

Declarative widgets for ModelForm

Reported by: isagalaev Owned by: nobody
Component: Forms Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Implementation of widgets attribute of inner Meta class of ModelForm. The whole (but short!) discussion is here: http://groups.google.com/group/django-developers/browse_frm/thread/f879f383870b92c1

Attachments (4)

9223.diff (5.8 KB) - added by isagalaev 6 years ago.
Patch with test and docs
9223.2.diff (5.6 KB) - added by isagalaev 6 years ago.
Patch correcting the bug with shared dict
9223.3.diff (5.6 KB) - added by isagalaev 5 years ago.
Patch updated to current trunk
9223.4.diff (5.6 KB) - added by isagalaev 4 years ago.
Patch updated to current trunk

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by isagalaev

Patch with test and docs

comment:1 Changed 6 years ago by isagalaev

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 6 years ago by SmileyChris

Bug: You're sharing the kwargs dict, so it'll get applied to all following fields.

Changed 6 years ago by isagalaev

Patch correcting the bug with shared dict

comment:3 Changed 6 years ago by isagalaev

Good catch, thanks! I've fixed the bug and added a test specifically for this issue.

comment:4 Changed 5 years ago by jacob

  • Triage Stage changed from Unreviewed to Accepted

Changed 5 years ago by isagalaev

Patch updated to current trunk

comment:5 Changed 5 years ago by simon29

  • Triage Stage changed from Accepted to Ready for checkin

This patch isn't present in rev 11440.

Changed 4 years ago by isagalaev

Patch updated to current trunk

comment:6 Changed 4 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [12194]) Fixed #9223 -- Added support for declarative widgets to ModelForm. I declare thanks to isagalaev.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.