KeyError in validate_unique when primary_key is in fields and it's empty in form

[romke <rombar@…>]

1. create model with custom primary_key:

class Test(models.Model):
  testing = models.CharField(max_length=20, primary_key=True)

2. create form:

class TestForm(forms.ModelForm):
  class Meta:
    model = Test
    fields = ('testing')

3. POST EMPTY testing field

KeyError @ forms/models.py in validate_unique, line 235 will pop up

[romke <rombar@…>]

patch for this one

[Malcolm Tredinnick]

I think this could be better written as self.cleaned_data.get(name), since that will return None when it's missing (and the following line won't execute if the name is missing from cleaned_data. So the code is a bit simpler.

Also, this should really have a test to make sure we don't reintroduce the problem. There's a regression tests file in the forms test directory.

[romke <rombar@…>]

patch using get(name) as suggested

[romke <rombar@…>]

tested as suggested

[romke <rombar@…>]

Sorry, Did not understood part about creating test for it.
I'll attach test for that in few hours.

[romke <rombar@…>]

test for fix

[romke <rombar@…>]

better patch added, tests added

[Julian Bez]

My form didn't work at all. I can confirm that this patch fixes it. Thanks!

[Karen Tracey]

Minor, but the attached patch uses 2-space indents while the rest of the code in the file uses 4-space -- in the future please code patches in the style of the surrounding code.

This error was actually fixed by the fix for #9039 but that fix didn't use the simpler-code get approach suggested above. I'll fix that and add a test for this to ensure it doesn't get broken again in the future.

[Karen Tracey]

(In [9342]) [1.0.X] Fixed #9218 -- Simplified the fix from #9039 and added tests to ensure this case doesn't break again (and that the simplification didn't break anything).

[9341] from trunk. Also updated svnmerge metadata.