Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9203 closed (fixed)

LatestCommentFeed syndicates old comments

Reported by: hanksims Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords: syndication, rss
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

LatestCommentFeed is actually OldestCommentFeed.

It selects and returns the 40 oldest comments, ordering them by ascending submit_date. It should select and return the 40 newest comments, ordering them by descending submit_date.

Attachments (2)

feeds.py.diff (586 bytes) - added by hanksims 7 years ago.
django/contrib/comments/feeds.py
9203.diff (665 bytes) - added by thejaswi_puthraya 7 years ago.
git-patch of the latest checkout

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by hanksims

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

LatestCommentFeed? is actually OldestCommentFeed?.

It selects and returns the 40 oldest comments, ordering them by ascending submit_date. It should select and return the 40 newest comments, ordering them by descending submit_date.

Seems to be a cousin of #8917.

Changed 7 years ago by hanksims

django/contrib/comments/feeds.py

comment:2 follow-up: Changed 7 years ago by hanksims

  • Has patch set

Sorry -- I can't attach my patch, for whatever reason. Here it is on dpaste:

http://dpaste.com/hold/80484/

comment:3 in reply to: ↑ 2 Changed 7 years ago by thejaswi_puthraya

  • Triage Stage changed from Unreviewed to Accepted
  • Version changed from 1.0 to SVN

Replying to hanksims:

Sorry -- I can't attach my patch, for whatever reason. Here it is on dpaste:

http://dpaste.com/hold/80484/

Your patch is available don't worry about it. I am enclosing your patch once more.

Changed 7 years ago by thejaswi_puthraya

git-patch of the latest checkout

comment:4 Changed 7 years ago by ubernostrum

  • Resolution set to fixed
  • Status changed from new to closed

(In [9088]) Fixed #9203: Restore correct ordering for LatestCommentsFeed

comment:5 Changed 7 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top