Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#9203 closed (fixed)

LatestCommentFeed syndicates old comments

Reported by: hanksims Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords: syndication, rss
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

LatestCommentFeed is actually OldestCommentFeed.

It selects and returns the 40 oldest comments, ordering them by ascending submit_date. It should select and return the 40 newest comments, ordering them by descending submit_date.

Attachments (2)

feeds.py.diff (586 bytes) - added by hanksims 8 years ago.
django/contrib/comments/feeds.py
9203.diff (665 bytes) - added by Thejaswi Puthraya 8 years ago.
git-patch of the latest checkout

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by hanksims

LatestCommentFeed? is actually OldestCommentFeed?.

It selects and returns the 40 oldest comments, ordering them by ascending submit_date. It should select and return the 40 newest comments, ordering them by descending submit_date.

Seems to be a cousin of #8917.

Changed 8 years ago by hanksims

Attachment: feeds.py.diff added

django/contrib/comments/feeds.py

comment:2 Changed 8 years ago by hanksims

Has patch: set

Sorry -- I can't attach my patch, for whatever reason. Here it is on dpaste:

http://dpaste.com/hold/80484/

comment:3 in reply to:  2 Changed 8 years ago by Thejaswi Puthraya

Triage Stage: UnreviewedAccepted
Version: 1.0SVN

Replying to hanksims:

Sorry -- I can't attach my patch, for whatever reason. Here it is on dpaste:

http://dpaste.com/hold/80484/

Your patch is available don't worry about it. I am enclosing your patch once more.

Changed 8 years ago by Thejaswi Puthraya

Attachment: 9203.diff added

git-patch of the latest checkout

comment:4 Changed 8 years ago by James Bennett

Resolution: fixed
Status: newclosed

(In [9088]) Fixed #9203: Restore correct ordering for LatestCommentsFeed

comment:5 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top