Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#9189 closed Bug (fixed)

urlize filter doesn't do .us domains without http and www

Reported by: Greg Allard Owned by: dArignac
Component: Documentation Version: 1.0
Severity: Normal Keywords: urlize, filter
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Try tinyid.us as an example. This passes the url field test, but doesn't get urlized.

Attachments (2)

9189.diff (499 bytes) - added by ericholscher 6 years ago.
9189-r16351.diff (573 bytes) - added by dArignac 4 years ago.
path for current source

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by ericholscher

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

The docstring for urlize says that it only works on .com .org and .net domains. I think this is meant to urlize the simple cases of common urls.

I'm accepting this ticket, because it either needs to be documented that it only works for those three TLD's, or it needs to be fixed so that it works for any "URL looking string". That has problems (such as marking non-urls as urls), so I'm assuming fixing the docs is the correct result.

Current docs: http://docs.djangoproject.com/en/dev/ref/templates/builtins/?from=olddocs#urlize

Changed 6 years ago by ericholscher

comment:2 Changed 4 years ago by lukeplant

  • Severity set to Normal
  • Type set to Bug

comment:3 Changed 4 years ago by dArignac

  • Easy pickings unset
  • Owner changed from nobody to dArignac
  • Status changed from new to assigned
  • UI/UX unset

Changed 4 years ago by dArignac

path for current source

comment:4 Changed 4 years ago by dArignac

  • Has patch set

i updated the patch to the current source

comment:5 Changed 4 years ago by jezdez

  • Component changed from Template system to Documentation
  • Triage Stage changed from Accepted to Ready for checkin

comment:6 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from assigned to closed

In [16372]:

Fixed #9189 -- Added not about urlize only covering .com, .net, and .org domains. Thanks, dArignac.

comment:7 Changed 4 years ago by SmileyChris

In [16470]:

More accurate documentation for how the urlize template works. Refs #9189.

Note: See TracTickets for help on using tickets.
Back to Top