Opened 11 years ago

Closed 11 years ago

#915 closed defect (fixed)

Admin breadcrumb links assume app is rooted at /admin/

Reported by: oggie rob Owned by: Adrian Holovaty
Component: contrib.admin Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Hi,
The new admin branch is awesome! However while nothing broke from the previous branch it highlighted a problem with the breadcrumb links. So far I have seen two issues - there may be more:

  1. If you change the name of your project to something other than admin - in your urls.py file - then at least the change password/logout links will fail. There are probably others.
  2. The default link (in base.html) won't take you to the home admin page. I don't think this is intended as most screens will actually take you to the admin home location, but in some cases it will take you to the server root location. An example is the "confirm delete" page, where the link will be "http://localhost:8000/" using the development server (this may not be a problem in other environments depending on how the web server segments django).

Anyway, throughout template code the href links look quite "fragile" - relative links so they assume certain locations, etc. I wonder if there is a solution (using, say, template tags) that will offer the project name, app name, module and/or action to help direct. I guess this still assumes certain locations but might be a little less likely to fail under some modifications.

Change History (2)

comment:1 Changed 11 years ago by Adrian Holovaty

Summary: breadcrumb links break easilyAdmin breadcrumb links assume app is rooted at /admin/

comment:2 Changed 11 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

Fixed in [1521]. Lemme know if I missed any links.

Note: See TracTickets for help on using tickets.
Back to Top