Opened 8 years ago

Closed 7 years ago

Last modified 5 years ago

#9147 closed (fixed)

FormPreview needs easier extensibility

Reported by: Bob Thomas Owned by: nobody
Component: contrib.formtools Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In addition to #7222 and #8690, I have to override more parts of FormPreview than I'd like to do any additional processing before displaying the preview page. FormPreview should have a hook for additional processing like FormWizard's process_step() method so I don't have to override all of preview_post or put unwanted logic in my template.

Attachments (2)

preview_9070.diff (1.1 KB) - added by Bob Thomas 8 years ago.
Add a process_preview method to FormPreview
process_preview_doc.diff (881 bytes) - added by thalin 7 years ago.
Basic docs for process_preview; indicating new in 1.2

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Bob Thomas

Attachment: preview_9070.diff added

Add a process_preview method to FormPreview

comment:1 Changed 8 years ago by Bob Thomas

Needs documentation: set

As a bonus, this doesn't break backwards compatibility :)

comment:2 Changed 8 years ago by Jacob

milestone: 1.1
Triage Stage: UnreviewedAccepted

comment:3 Changed 8 years ago by Jacob

milestone: 1.11.2

Changed 7 years ago by thalin

Attachment: process_preview_doc.diff added

Basic docs for process_preview; indicating new in 1.2

comment:4 Changed 7 years ago by jbronn

Resolution: fixed
Status: newclosed

(In [12486]) Fixed #9147 -- Added FormPreview.process_preview customization hook. Thanks, bthomas and thalin.

comment:5 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top