Code

Opened 6 years ago

Closed 4 years ago

Last modified 3 years ago

#9147 closed (fixed)

FormPreview needs easier extensibility

Reported by: bthomas Owned by: nobody
Component: contrib.formtools Version: 1.0
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In addition to #7222 and #8690, I have to override more parts of FormPreview than I'd like to do any additional processing before displaying the preview page. FormPreview should have a hook for additional processing like FormWizard's process_step() method so I don't have to override all of preview_post or put unwanted logic in my template.

Attachments (2)

preview_9070.diff (1.1 KB) - added by bthomas 6 years ago.
Add a process_preview method to FormPreview
process_preview_doc.diff (881 bytes) - added by thalin 4 years ago.
Basic docs for process_preview; indicating new in 1.2

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by bthomas

Add a process_preview method to FormPreview

comment:1 Changed 6 years ago by bthomas

  • Needs documentation set
  • Needs tests unset
  • Patch needs improvement unset

As a bonus, this doesn't break backwards compatibility :)

comment:2 Changed 5 years ago by jacob

  • milestone set to 1.1
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 5 years ago by jacob

  • milestone changed from 1.1 to 1.2

Changed 4 years ago by thalin

Basic docs for process_preview; indicating new in 1.2

comment:4 Changed 4 years ago by jbronn

  • Resolution set to fixed
  • Status changed from new to closed

(In [12486]) Fixed #9147 -- Added FormPreview.process_preview customization hook. Thanks, bthomas and thalin.

comment:5 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.