Code

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9100 closed (fixed)

django.contrib.comments missing css class attributes in two preview templates

Reported by: mordyovits Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

django/contrib/comments/templates/comments has preview.html and reply_preview.html. Both of them have an input field as follows:

and <input type="submit" name="submit" value="Post your comment" id="submit"> or make changes:

It's missing a class="submit-post" attribute, making it impossible to keep button styling consistent without modifying the template.

Attachments (2)

comments-button-style.patch (1.2 KB) - added by mordyovits 6 years ago.
patch adding class attribute to preview templates
9100.diff (690 bytes) - added by thejaswi_puthraya 6 years ago.
git-patch against the latest checkout

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by mordyovits

patch adding class attribute to preview templates

comment:1 Changed 6 years ago by mordyovits

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Version changed from 1.0 to SVN

Changed 6 years ago by thejaswi_puthraya

git-patch against the latest checkout

comment:2 Changed 6 years ago by thejaswi_puthraya

  • Triage Stage changed from Unreviewed to Accepted

It's a trivial change, yet worth getting it done. Am uploading an updated patch based on mordyovits' but without the one for reply_preview.html. For more details check #9141.

comment:3 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [9120]) Fixed #9100 -- Added a missing CSS class to a submit button.
Thanks, mordyovits and thejaswi_puthraya.

comment:4 Changed 6 years ago by mtredinnick

(In [9127]) [1.0.X] Fixed #9100 -- Added a missing CSS class to a submit button.
Thanks, mordyovits and thejaswi_puthraya.

Backport of r9120 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.