Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#9100 closed (fixed)

django.contrib.comments missing css class attributes in two preview templates

Reported by: mordyovits Owned by: nobody
Component: contrib.comments Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

django/contrib/comments/templates/comments has preview.html and reply_preview.html. Both of them have an input field as follows:

and <input type="submit" name="submit" value="Post your comment" id="submit"> or make changes:

It's missing a class="submit-post" attribute, making it impossible to keep button styling consistent without modifying the template.

Attachments (2)

comments-button-style.patch (1.2 KB ) - added by mordyovits 16 years ago.
patch adding class attribute to preview templates
9100.diff (690 bytes ) - added by Thejaswi Puthraya 16 years ago.
git-patch against the latest checkout

Download all attachments as: .zip

Change History (6)

by mordyovits, 16 years ago

Attachment: comments-button-style.patch added

patch adding class attribute to preview templates

comment:1 by mordyovits, 16 years ago

Version: 1.0SVN

by Thejaswi Puthraya, 16 years ago

Attachment: 9100.diff added

git-patch against the latest checkout

comment:2 by Thejaswi Puthraya, 16 years ago

Triage Stage: UnreviewedAccepted

It's a trivial change, yet worth getting it done. Am uploading an updated patch based on mordyovits' but without the one for reply_preview.html. For more details check #9141.

comment:3 by Malcolm Tredinnick, 16 years ago

Resolution: fixed
Status: newclosed

(In [9120]) Fixed #9100 -- Added a missing CSS class to a submit button.
Thanks, mordyovits and thejaswi_puthraya.

comment:4 by Malcolm Tredinnick, 16 years ago

(In [9127]) [1.0.X] Fixed #9100 -- Added a missing CSS class to a submit button.
Thanks, mordyovits and thejaswi_puthraya.

Backport of r9120 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top